Uh oh!
There was an error while loading. Please reload this page.
[SPARK-15232][SQL] Add subquery SQL building tests to LogicalPlanToSQLSuite - #14383
Closed
dongjoon-hyun wants to merge 4 commits into
Closed
[SPARK-15232][SQL] Add subquery SQL building tests to LogicalPlanToSQLSuite#14383dongjoon-hyun wants to merge 4 commits into
dongjoon-hyun wants to merge 4 commits into
Conversation
dongjoon-hyun
commented
Jul 27, 2016
MemberAuthor
cc @hvanhovell and @rxin |
| "mapjoin_subquery") | ||
| } | ||
| test("subq2") { |
Contributor
There was a problem hiding this comment.
is there a more descriptive name?
MemberAuthor
There was a problem hiding this comment.
Sure. I actually just use the name from Hive suite for review.
I'll review this.
SparkQA
commented
Jul 27, 2016
Test build #62936 has finished for PR 14383 at commit
|
SparkQA
commented
Jul 27, 2016
Test build #62938 has finished for PR 14383 at commit
|
SparkQA
commented
Jul 27, 2016
Test build #62941 has finished for PR 14383 at commit
|
SparkQA
commented
Jul 27, 2016
Test build #62942 has finished for PR 14383 at commit
|
dongjoon-hyun
commented
Jul 28, 2016
MemberAuthor
Hi, @rxin and @hvanhovell . |
rxin
commented
Jul 28, 2016
Contributor
Looks reasonable to me. Merging in master/2.0. |
asfgit pushed a commit
that referenced
this pull request
Jul 28, 2016
…LSuite ## What changes were proposed in this pull request? We currently test subquery SQL building using the `HiveCompatibilitySuite`. The is not desired since SQL building is actually a part of `sql/core` and because we are slowly reducing our dependency on Hive. This PR adds the same tests from the whitelist of `HiveCompatibilitySuite` into `LogicalPlanToSQLSuite`. ## How was this patch tested? This adds more testcases. Pass the Jenkins tests. Author: Dongjoon Hyun <dongjoon@apache.org> Closes#14383 from dongjoon-hyun/SPARK-15232. (cherry picked from commit 5c2ae79) Signed-off-by: Reynold Xin <rxin@databricks.com>
dongjoon-hyun
commented
Jul 28, 2016
MemberAuthor
Thank you for review and merging, @rxin . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We currently test subquery SQL building using the
HiveCompatibilitySuite. The is not desired since SQL building is actually a part ofsql/coreand because we are slowly reducing our dependency on Hive. This PR adds the same tests from the whitelist ofHiveCompatibilitySuiteintoLogicalPlanToSQLSuite.How was this patch tested?
This adds more testcases. Pass the Jenkins tests.