Skip to content

[SPARK-16606] [CORE] Misleading warning for SparkContext.getOrCreate "WARN SparkContext: Use an existing SparkContext, some configuration may not take effect." - #14533

Closed
srowen wants to merge 1 commit into
apache:masterfrom
srowen:SPARK-16606

Conversation

@srowen

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

SparkContext.getOrCreate shouldn't warn about ignored config if

  • it wasn't ignored because a new context is created with it or
  • no config was actually provided

How was this patch tested?

Jenkins + existing tests.

… wasn't ignored because a new context is created with it or b) no config was actually provided
@SparkQA

Copy link
Copy Markdown

Test build #63344 has finished for PR 14533 at commit 784f678.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@markhamstra

Copy link
Copy Markdown
Contributor

PR title typo? Intended "misleading"?

@srowensrowen changed the title [SPARK-16606] [CORE] isleading warning for SparkContext.getOrCreate "WARN SparkContext: Use an existing SparkContext, some configuration may not take effect."[SPARK-16606] [CORE] Misleading warning for SparkContext.getOrCreate "WARN SparkContext: Use an existing SparkContext, some configuration may not take effect."Aug 8, 2016
@jaceklaskowski

Copy link
Copy Markdown
Contributor

LGTM

@srowen

Copy link
Copy Markdown
MemberAuthor

Merged to master

@asfgitasfgit closed this in 801e4d0Aug 9, 2016
@srowen
srowen deleted the SPARK-16606 branch August 9, 2016 08:41
asfgit pushed a commit that referenced this pull request Oct 22, 2016
… the same log message typo
## What changes were proposed in this pull request?
Tiny follow-up to SPARK-16606 / #14533 , to correct more instances of the same log message typo
## How was this patch tested?
Existing tests (no functional change anyway)
Author: Sean Owen <sowen@cloudera.com>
Closes#15586 from srowen/SPARK-16606.2.
(cherry picked from commit 7178c56)
Signed-off-by: Reynold Xin <rxin@databricks.com>
asfgit pushed a commit that referenced this pull request Oct 22, 2016
… the same log message typo
## What changes were proposed in this pull request?
Tiny follow-up to SPARK-16606 / #14533 , to correct more instances of the same log message typo
## How was this patch tested?
Existing tests (no functional change anyway)
Author: Sean Owen <sowen@cloudera.com>
Closes#15586 from srowen/SPARK-16606.2.
robert3005 pushed a commit to palantir/spark that referenced this pull request Nov 1, 2016
… the same log message typo
## What changes were proposed in this pull request?
Tiny follow-up to SPARK-16606 / apache#14533 , to correct more instances of the same log message typo
## How was this patch tested?
Existing tests (no functional change anyway)
Author: Sean Owen <sowen@cloudera.com>
Closesapache#15586 from srowen/SPARK-16606.2.
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
… the same log message typo
## What changes were proposed in this pull request?
Tiny follow-up to SPARK-16606 / apache#14533 , to correct more instances of the same log message typo
## How was this patch tested?
Existing tests (no functional change anyway)
Author: Sean Owen <sowen@cloudera.com>
Closesapache#15586 from srowen/SPARK-16606.2.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@srowen@SparkQA@markhamstra@jaceklaskowski