Uh oh!
There was an error while loading. Please reload this page.
[SPARK-17007][SQL] Move test data files into a test-data folder - #14589
[SPARK-17007][SQL] Move test data files into a test-data folder#14589petermaxlee wants to merge 2 commits into
Conversation
SparkQA
commented
Aug 11, 2016
Test build #63571 has finished for PR 14589 at commit
|
SparkQA
commented
Aug 11, 2016
Test build #63573 has finished for PR 14589 at commit
|
rxin
commented
Aug 11, 2016
Thanks - merging in master. |
srowen
commented
Aug 11, 2016
Seems OK, but src/test/resources was already only a "test data" dir by nature. I don't think this helped anything. |
## What changes were proposed in this pull request? This patch moves all the test data files in sql/core/src/test/resources to sql/core/src/test/resources/test-data, so we don't clutter the top level sql/core/src/test/resources. Also deleted sql/core/src/test/resources/old-repeated.parquet since it is no longer used. The change will make it easier to spot sql-tests directory. ## How was this patch tested? This is a test-only change. Author: petermaxlee <petermaxlee@gmail.com> Closes#14589 from petermaxlee/SPARK-17007. (cherry picked from commit 665e175) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
cloud-fan
commented
Aug 11, 2016
backport to 2.0! |
srowen
commented
Aug 11, 2016
@cloud-fan why backport into a maintenance release? |
rxin
commented
Aug 11, 2016
@srowen there are bug fixes that are tested by this new harness (technically not super relevant to this pr though, but all those files are in the same resources directory). |
I see. This is also why I would not have made this change. Can you leave these open for >= 1 day if it's not an emergency? last week I saw a JIRA + PR opened and closed in 2 hours. We should try not to |
What changes were proposed in this pull request?
This patch moves all the test data files in sql/core/src/test/resources to sql/core/src/test/resources/test-data, so we don't clutter the top level sql/core/src/test/resources. Also deleted sql/core/src/test/resources/old-repeated.parquet since it is no longer used.
The change will make it easier to spot sql-tests directory.
How was this patch tested?
This is a test-only change.