Uh oh!
There was an error while loading. Please reload this page.
SPARK-12868: Allow Add jar to add jars from hdfs/s3n urls. - #14720
SPARK-12868: Allow Add jar to add jars from hdfs/s3n urls.#14720Parth-Brahmbhatt wants to merge 2 commits into
Conversation
AmplabJenkins
commented
Aug 19, 2016
Can one of the admins verify this patch? |
66dfb69 to
078f05aCompareParth-Brahmbhatt
commented
Aug 31, 2016
Can one of the committers take a look at this PR? |
1 similar comment
Parth-Brahmbhatt
commented
Sep 8, 2016
Can one of the committers take a look at this PR? |
Parth-Brahmbhatt
commented
Sep 14, 2016
Request for review one more time. |
Parth-Brahmbhatt
commented
Sep 28, 2016
Ping. |
Parth-Brahmbhatt
commented
Oct 19, 2016
Request for review. |
felixcheung
commented
Oct 19, 2016
@srowen would this make sense to you? |
| val testJar = "hdfs://nn:8020/foo.jar" | ||
| // This should fail with unknown host, as its just testing the URL parsing | ||
| // before SPARK-12868 it was failing with Malformed URI | ||
| val e = intercept[RuntimeException] { |
There was a problem hiding this comment.
I think this test should be improved before merging this. Looking for a RuntimeException to validate that the Jar was registered is brittle and can easily pass when the registration doesn't actually work.
HyukjinKwon
commented
May 11, 2017
Hi @Parth-Brahmbhatt, is it still active? If so is there any argument against #14720 (comment)? |
wangyum
commented
May 11, 2017
It has been fixed by #17342. |
HyukjinKwon
commented
May 12, 2017
I will propose to close this after a week if it is still inactive or no objection to ^. |
Parth-Brahmbhatt
commented
May 12, 2017
closing. |
What changes were proposed in this pull request?
Add jar command fails when given s3n or hdfs urls. This changes fixes that.
How was this patch tested?
unit test added, it was just copied from a previously opened PR #10797 so credit should be given to the person who originally posted the patch.