Uh oh!
There was an error while loading. Please reload this page.
[SPARK-17257][SQL] the physical plan of CREATE TABLE or CTAS should take CatalogTable - #14823
[SPARK-17257][SQL] the physical plan of CREATE TABLE or CTAS should take CatalogTable#14823cloud-fan wants to merge 3 commits into
Conversation
cloud-fan
commented
Aug 26, 2016
SparkQA
commented
Aug 26, 2016
Test build #64461 has finished for PR 14823 at commit
|
SparkQA
commented
Aug 27, 2016
Test build #64525 has finished for PR 14823 at commit
|
gatorsmile
commented
Aug 31, 2016
I missed this ping. Will review it tomorrow. |
| // TODO: this may be wrong for non file-based data source like JDBC, which should be external | ||
| // even there is no `path` in options. We should consider allow the EXTERNAL keyword. | ||
| val tableType = if (new CaseInsensitiveMap(options).contains("path")) { | ||
| CatalogTableType.EXTERNAL |
There was a problem hiding this comment.
After this PR, it becomes much clear to users. We can support Create External Data Source Table! We just need to confirm the path is provided.
There was a problem hiding this comment.
removing this means we change the syntax, I'd like to avoid it in this PR, and that's why I leave this TODO here, we can do it in follow-up
gatorsmile
commented
Sep 1, 2016
LGTM except one minor comment. |
SparkQA
commented
Sep 1, 2016
Test build #64759 has finished for PR 14823 at commit
|
SparkQA
commented
Sep 1, 2016
Test build #64762 has finished for PR 14823 at commit
|
cloud-fan
commented
Sep 1, 2016
thanks for the review, merging to master! |
What changes were proposed in this pull request?
This is kind of a follow-up of #14482 . As we put
CatalogTablein the logical plan directly, it makes sense to let physical plans takeCatalogTabledirectly, instead of extracting some fields ofCatalogTablein planner and then construct a newCatalogTablein physical plan.How was this patch tested?
existing tests.