Uh oh!
There was an error while loading. Please reload this page.
[SPARK-17299] TRIM/LTRIM/RTRIM should not strips characters other than spaces - #14924
Closed
techaddict wants to merge 4 commits into
Closed
[SPARK-17299] TRIM/LTRIM/RTRIM should not strips characters other than spaces#14924techaddict wants to merge 4 commits into
techaddict wants to merge 4 commits into
Conversation
SparkQA
commented
Sep 1, 2016
Test build #64798 has finished for PR 14924 at commit
|
rxin
commented
Sep 2, 2016
Contributor
Can you add a unit test for this? |
techaddict
commented
Sep 2, 2016
ContributorAuthor
@rxin Done 👍 |
SparkQA
commented
Sep 2, 2016
Test build #64827 has finished for PR 14924 at commit
|
srowen
commented
Sep 2, 2016
Member
The implementation in |
ContributorAuthor
@srowen yes in stringExpressions the |
SparkQA
commented
Sep 2, 2016
Test build #64856 has finished for PR 14924 at commit
|
srowen
commented
Sep 3, 2016
Member
LGTM. Seems like this should go into 2.0.x as well since it's really a bug fix. |
srowen
commented
Sep 6, 2016
Member
Merged to master/2.0 |
1 similar comment
srowen
commented
Sep 6, 2016
Member
Merged to master/2.0 |
asfgit pushed a commit
that referenced
this pull request
Sep 6, 2016
…n spaces ## What changes were proposed in this pull request? TRIM/LTRIM/RTRIM should not strips characters other than spaces, we were trimming all chars small than ASCII 0x20(space) ## How was this patch tested? fixed existing tests. Author: Sandeep Singh <sandeep@techaddict.me> Closes#14924 from techaddict/SPARK-17299. (cherry picked from commit 7775d9f) Signed-off-by: Sean Owen <sowen@cloudera.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TRIM/LTRIM/RTRIM should not strips characters other than spaces, we were trimming all chars small than ASCII 0x20(space)
How was this patch tested?
fixed existing tests.