Skip to content

[SPARK-17391] [TEST] [2.0] Fix Two Test Failures After Backport - #14951

Closed
gatorsmile wants to merge 1 commit into
apache:branch-2.0from
gatorsmile:fixTestFailure
Closed

[SPARK-17391] [TEST] [2.0] Fix Two Test Failures After Backport#14951
gatorsmile wants to merge 1 commit into
apache:branch-2.0from
gatorsmile:fixTestFailure

Conversation

@gatorsmile

@gatorsmilegatorsmile commented Sep 3, 2016

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

In the latest branch 2.0, we have two test case failure due to backport.

  • test("ALTER VIEW AS should keep the previous table properties, comment, create_time, etc.")
  • test("SPARK-6212: The EXPLAIN output of CTAS only shows the analyzed plan")

How was this patch tested?

N/A

@gatorsmile

gatorsmile commented Sep 3, 2016

Copy link
Copy Markdown
MemberAuthor

cc @cloud-fan@hvanhovell@davies@sameeragarwal

@gatorsmilegatorsmile changed the title [SPARK-17391] [TEST] Fix Two Test Failures After Backport[SPARK-17391] [TEST] [2.0] Fix Two Test Failures After BackportSep 3, 2016
@SparkQA

SparkQA commented Sep 3, 2016

Copy link
Copy Markdown

Test build #64907 has finished for PR 14951 at commit 2f02bed.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

cloud-fan
cloud-fan reviewed Sep 4, 2016
View reviewed changes
Comment threadsql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveExplainSuite.scala
}

test("SPARK-6212: The EXPLAIN output of CTAS only shows the analyzed plan") {
test("SPARK-17230: The EXPLAIN output of CTAS only shows the analyzed plan") {

@cloud-fancloud-fanSep 4, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did we break this test?

@gatorsmilegatorsmileSep 4, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we backporting this PR: #14797 , it breaks the existing test case. It does not correctly work in the master branch. If we do not want to optimize the query of CTAS, we should see SubqueryAlias. Thus, the test case did not fail in the master branch.

@cloud-fan

cloud-fan commented Sep 4, 2016

Copy link
Copy Markdown
Contributor

thanks for fixing it! Sorry this is my bad, I should be more careful when backporting DDL related bug fixes to 2.0, as the code of master and 2.0 differ a lot now.

@gatorsmile

gatorsmile commented Sep 4, 2016

Copy link
Copy Markdown
MemberAuthor

Yeah, it is a little bit painful when we backport the PRs. When I backported CREATE TABLE LIKE, I found I already forgot how CREATE TABLE works in Spark 2.0. : )

asfgit pushed a commit that referenced this pull request Sep 5, 2016
@gatorsmile@cloud-fan
[SPARK-17391][TEST][2.0] Fix Two Test Failures After Backport
e387c8b
### What changes were proposed in this pull request?
In the latest branch 2.0, we have two test case failure due to backport.
- test("ALTER VIEW AS should keep the previous table properties, comment, create_time, etc.")
- test("SPARK-6212: The EXPLAIN output of CTAS only shows the analyzed plan")
### How was this patch tested?
N/A
Author: gatorsmile <gatorsmile@gmail.com>
Closes#14951 from gatorsmile/fixTestFailure.
@cloud-fan

cloud-fan commented Sep 5, 2016

Copy link
Copy Markdown
Contributor

thanks, merging to 2.0!

@gatorsmile

gatorsmile commented Sep 5, 2016•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Since it is merged, I close it now. Thanks!

@gatorsmilegatorsmile mentioned this pull request Sep 6, 2016
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gatorsmile@SparkQA@cloud-fan