Skip to content

Correct fetchsize property name in docs - #14975

Closed
darabos wants to merge 2 commits into
apache:masterfrom
darabos:patch-3
Closed

Correct fetchsize property name in docs#14975
darabos wants to merge 2 commits into
apache:masterfrom
darabos:patch-3

Conversation

@darabos

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Replace fetchSize with fetchsize in the docs.

How was this patch tested?

I manually tested fetchSize and fetchsize. The latter has an effect. See also JdbcUtils.scala#L38 for the definition of the property.

Property is defined at JdbcUtils.scala#L38.
@srowen

Copy link
Copy Markdown
Member

+1. There are other occurrences of "FetchSize" or "fetchSize" in the code, though none will matter for users (i.e. test names). But feel free to fix them.

@darabos

Copy link
Copy Markdown
ContributorAuthor

+1. There are other occurrences of "FetchSize" or "fetchSize" in the code, though none will matter for users (i.e. test names). But feel free to fix them.

Good point! I'll update the pull request next week. (Sorry for the delay.)

@srowen

Copy link
Copy Markdown
Member

@darabos do you want to close this out or should I do the update?

@darabos

Copy link
Copy Markdown
ContributorAuthor

@darabos do you want to close this out or should I do the update?

Sorry! I'll try to do it tonight. If I don't report back, consider me eaten by a monster.

@darabos

Copy link
Copy Markdown
ContributorAuthor

+1. There are other occurrences of "FetchSize" or "fetchSize" in the code, though none will matter for users (i.e. test names). But feel free to fix them.

Done.

@SparkQA

Copy link
Copy Markdown

Test build #3278 has finished for PR 14975 at commit f820ea2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen

Copy link
Copy Markdown
Member

Merged to master/2.0

asfgit pushed a commit that referenced this pull request Sep 17, 2016
## What changes were proposed in this pull request?
Replace `fetchSize` with `fetchsize` in the docs.
## How was this patch tested?
I manually tested `fetchSize` and `fetchsize`. The latter has an effect. See also [`JdbcUtils.scala#L38`](https://github.com/apache/spark/blob/v2.0.0/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala#L38) for the definition of the property.
Author: Daniel Darabos <darabos.daniel@gmail.com>
Closes#14975 from darabos/patch-3.
(cherry picked from commit 69cb049)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@darabos
darabos deleted the patch-3 branch September 19, 2016 13:11
wgtmac pushed a commit to wgtmac/spark that referenced this pull request Sep 19, 2016
## What changes were proposed in this pull request?
Replace `fetchSize` with `fetchsize` in the docs.
## How was this patch tested?
I manually tested `fetchSize` and `fetchsize`. The latter has an effect. See also [`JdbcUtils.scala#L38`](https://github.com/apache/spark/blob/v2.0.0/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala#L38) for the definition of the property.
Author: Daniel Darabos <darabos.daniel@gmail.com>
Closesapache#14975 from darabos/patch-3.
zzcclp added a commit to zzcclp/spark that referenced this pull request Sep 20, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@darabos@srowen@SparkQA