Uh oh!
There was an error while loading. Please reload this page.
[SPARK-17336][PYSPARK] Fix appending multiple times to PYTHONPATH from spark-config.sh - #15028
[SPARK-17336][PYSPARK] Fix appending multiple times to PYTHONPATH from spark-config.sh#15028BryanCutler wants to merge 1 commit into
Conversation
BryanCutler
commented
Sep 9, 2016
@srowen mind taking a look? This seems to do the trick for me. Thanks! |
srowen
commented
Sep 9, 2016
Seems reasonable, LGTM |
SparkQA
commented
Sep 9, 2016
Test build #65158 has finished for PR 15028 at commit
|
holdenk
commented
Sep 9, 2016
My only concern is if someone has two different versions of Spark is this seems like it might result in weird behaviour if they want to launch jobs against seperate versions in the same shell (which might not seem likely - but think about doing something like performance testing between Spark versions). |
srowen
commented
Sep 10, 2016
I think the current behavior might be worse on that dimension ... you might get several different versions of things at once on the classpath, not just redundant copies. |
srowen
commented
Sep 11, 2016
I'll go ahead with this because I don't think it makes anything any worse. |
…m spark-config.sh ## What changes were proposed in this pull request? During startup of Spark standalone, the script file spark-config.sh appends to the PYTHONPATH and can be sourced many times, causing duplicates in the path. This change adds a env flag that is set when the PYTHONPATH is appended so it will happen only one time. ## How was this patch tested? Manually started standalone master/worker and verified PYTHONPATH has no duplicate entries. Author: Bryan Cutler <cutlerb@gmail.com> Closes#15028 from BryanCutler/fix-duplicate-pythonpath-SPARK-17336. (cherry picked from commit c76baff) Signed-off-by: Sean Owen <sowen@cloudera.com>
srowen
commented
Sep 11, 2016
Merged to master/2.0 |
holdenk
commented
Sep 11, 2016
Since the search order is defined the old behavior probably worked cross versions (albeit in an ugly fashion) - I'll follow up with some checks for spark-perf and fix there if necessary since I think that's really the main place which might have been dependent on this behavior. |
…m spark-config.sh ## What changes were proposed in this pull request? During startup of Spark standalone, the script file spark-config.sh appends to the PYTHONPATH and can be sourced many times, causing duplicates in the path. This change adds a env flag that is set when the PYTHONPATH is appended so it will happen only one time. ## How was this patch tested? Manually started standalone master/worker and verified PYTHONPATH has no duplicate entries. Author: Bryan Cutler <cutlerb@gmail.com> Closesapache#15028 from BryanCutler/fix-duplicate-pythonpath-SPARK-17336.
What changes were proposed in this pull request?
During startup of Spark standalone, the script file spark-config.sh appends to the PYTHONPATH and can be sourced many times, causing duplicates in the path. This change adds a env flag that is set when the PYTHONPATH is appended so it will happen only one time.
How was this patch tested?
Manually started standalone master/worker and verified PYTHONPATH has no duplicate entries.