[SPARK-17523] Support to generate build info file when building Spark in Windows

[Myasuka]

What changes were proposed in this pull request?

Currently, if we build Spark, it will generate a spark-version-info.properties and merged into spark-core_2.11-*.jar. However, the script build/spark-build-info which generates this file can only be executed with bash environment.
Without this file, errors like below will happen when submitting Spark application, which break the whole submitting phrase at beginning.

RRORApplicationMaster: Uncaughtexception: org.apache.spark.SparkException: ExceptionthrowninawaitResult: atorg.apache.spark.util.ThreadUtils$.awaitResult(ThreadUtils.scala:194)
atorg.apache.spark.deploy.yarn.ApplicationMaster.runDriver(ApplicationMaster.scala:394)
atorg.apache.spark.deploy.yarn.ApplicationMaster.run(ApplicationMaster.scala:247)
atorg.apache.spark.deploy.yarn.ApplicationMaster$$anonfun$main$1.apply$mcV$sp(ApplicationMaster.scala:759)
atorg.apache.spark.deploy.SparkHadoopUtil$$anon$1.run(SparkHadoopUtil.scala:67)
atorg.apache.spark.deploy.SparkHadoopUtil$$anon$1.run(SparkHadoopUtil.scala:66)
atjava.security.AccessController.doPrivileged(NativeMethod)
atjavax.security.auth.Subject.doAs(Subject.java:422)
atorg.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1657)
atorg.apache.spark.deploy.SparkHadoopUtil.runAsSparkUser(SparkHadoopUtil.scala:66)
atorg.apache.spark.deploy.yarn.ApplicationMaster$.main(ApplicationMaster.scala:757)
atorg.apache.spark.deploy.yarn.ApplicationMaster.main(ApplicationMaster.scala)
Causedby: java.util.concurrent.ExecutionException: BoxedErroratscala.concurrent.impl.Promise$.resolver(Promise.scala:55)
atscala.concurrent.impl.Promise$.scala$concurrent$impl$Promise$$resolveTry(Promise.scala:47)
atscala.concurrent.impl.Promise$DefaultPromise.tryComplete(Promise.scala:244)
atscala.concurrent.Promise$class.tryFailure(Promise.scala:112)
atscala.concurrent.impl.Promise$DefaultPromise.tryFailure(Promise.scala:153)
atorg.apache.spark.deploy.yarn.ApplicationMaster$$anon$2.run(ApplicationMaster.scala:648)
Causedby: java.lang.ExceptionInInitializerErroratorg.apache.spark.package$.<init>(package.scala:91)
atorg.apache.spark.package$.<clinit>(package.scala)
atorg.apache.spark.SparkContext$$anonfun$3.apply(SparkContext.scala:187)
atorg.apache.spark.SparkContext$$anonfun$3.apply(SparkContext.scala:187)
atorg.apache.spark.internal.Logging$class.logInfo(Logging.scala:54)
atorg.apache.spark.SparkContext.logInfo(SparkContext.scala:76)
atorg.apache.spark.SparkContext.<init>(SparkContext.scala:187)
atorg.apache.spark.SparkContext$.getOrCreate(SparkContext.scala:2287)
atorg.apache.spark.sql.SparkSession$Builder$$anonfun$6.apply(SparkSession.scala:822)
atorg.apache.spark.sql.SparkSession$Builder$$anonfun$6.apply(SparkSession.scala:814)
atscala.Option.getOrElse(Option.scala:121)
atorg.apache.spark.sql.SparkSession$Builder.getOrCreate(SparkSession.scala:814)
atorg.apache.spark.examples.SparkPi$.main(SparkPi.scala:31)
atorg.apache.spark.examples.SparkPi.main(SparkPi.scala)
atsun.reflect.NativeMethodAccessorImpl.invoke0(NativeMethod)
atsun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
atsun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
atjava.lang.reflect.Method.invoke(Method.java:498)
atorg.apache.spark.deploy.yarn.ApplicationMaster$$anon$2.run(ApplicationMaster.scala:630)
Causedby: org.apache.spark.SparkException: Errorwhilelocatingfilespark-version-info.propertiesatorg.apache.spark.package$SparkBuildInfo$.liftedTree1$1(package.scala:75)
atorg.apache.spark.package$SparkBuildInfo$.<init>(package.scala:61)
atorg.apache.spark.package$SparkBuildInfo$.<clinit>(package.scala)
... 19moreCausedby: java.lang.NullPointerExceptionatjava.util.Properties$LineReader.readLine(Properties.java:434)
atjava.util.Properties.load0(Properties.java:353)
atjava.util.Properties.load(Properties.java:341)
atorg.apache.spark.package$SparkBuildInfo$.liftedTree1$1(package.scala:64)
... 21more

I add build/spark-build-info.ps1 to generate spark-version-info.properties file in Windows, and modify core/pom.xml and project/SparkBuild.scala to support this scenario when building Spark with maven or sbt.

How was this patch tested?

Tested on my local Windows 10 machine, which generated the spark-version-info.properties under core/target/extra-resources folder as expected.

[srowen]

I don't think we support building on Windows. I think it's fine to make minor changes to accommodate Windows no matter what, but this is non-trivial.

[felixcheung]

+@HyukjinKwon we do windows for R

[HyukjinKwon]

Thanks for cc'ing me @felixcheung. Actually, I took a look and wanted to leave a comment but I didn't because I couldn't find a concrete reason or reference to support my opinion and also I know @srowen is an expert in this area.

FWIW and as I am already here - I tend to agree with Sean. I think it'd be nicer if all tests pass on Windows and pre-built releases work fine on Windows but it might not necessarily meam that we should support a proper build on Windows. Also, I know we mentioned that we support Windows in http://spark.apache.org/docs/latest/#downloading but I don't think this refers that we support to build Spark on Windows.

I am willing to take a close look if Sean/comitters approve and confirm that it is worth being added.

[SparkQA]

Test build #3274 has finished for PR 15078 at commit ffd219b.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[jodersky]

How wide-spread is powershell on windows computers? I assume that modern versions ship with it, but I also heard that they come with a bash-like shell in the latest version. Does the current build work in the new environment?

[HyukjinKwon]

FWIW, doesn't Power shell allows executing bash? (I haven't tried that by myself but I think I saw some usages and documentation before)

(Oh, this is what @jodersky pointed out right above)

[felixcheung]

I'm not sure older Windows versions have powershell installed by default..

It looks like Bash for Windows is Windows 10 only https://msdn.microsoft.com/en-us/commandline/wsl/install_guide

[HyukjinKwon]

From the discussion above, I would like to stay against this PR.

[Myasuka]

@jodersky Actually, BashOnWindows only exists on Windows10 Anniversary Update. Moreover, this feature needs to be manually enabled to take effects.

And I don't think this bash environment in BashOnWindows worked very well and stably so that could be used in production built in the short term.

[srowen]

Let's close this PR for now.

[guoxiaolongzte]

In Linux
mvn -Dtest=none -DwildcardSuites=org.apache.spark.deploy.rest.StandaloneRestSubmitSuite test
I want to know why?thank you!@HyukjinKwon
Report errors:
StandaloneRestSubmitSuite:
*** RUN ABORTED ***
java.lang.ExceptionInInitializerError:
at org.apache.spark.package$.(package.scala:91)
at org.apache.spark.package$.(package.scala)
at org.apache.spark.deploy.rest.RestSubmissionClient.constructSubmitRequest(RestSubmissionClient.scala:179)
at org.apache.spark.deploy.rest.StandaloneRestSubmitSuite$$anonfun$1.apply$mcV$sp(StandaloneRestSubmitSuite.scala:58)
at org.apache.spark.deploy.rest.StandaloneRestSubmitSuite$$anonfun$1.apply(StandaloneRestSubmitSuite.scala:54)
at org.apache.spark.deploy.rest.StandaloneRestSubmitSuite$$anonfun$1.apply(StandaloneRestSubmitSuite.scala:54)
at org.scalatest.Transformer$$anonfun$apply$1.apply$mcV$sp(Transformer.scala:22)
at org.scalatest.OutcomeOf$class.outcomeOf(OutcomeOf.scala:85)
at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
at org.scalatest.Transformer.apply(Transformer.scala:22)
...
Cause: org.apache.spark.SparkException: Error while locating file spark-version-info.properties
at org.apache.spark.package$SparkBuildInfo$.liftedTree1$1(package.scala:75)
at org.apache.spark.package$SparkBuildInfo$.(package.scala:61)
at org.apache.spark.package$SparkBuildInfo$.(package.scala)
at org.apache.spark.package$.(package.scala:91)
at org.apache.spark.package$.(package.scala)
at org.apache.spark.deploy.rest.RestSubmissionClient.constructSubmitRequest(RestSubmissionClient.scala:179)
at org.apache.spark.deploy.rest.StandaloneRestSubmitSuite$$anonfun$1.apply$mcV$sp(StandaloneRestSubmitSuite.scala:58)
at org.apache.spark.deploy.rest.StandaloneRestSubmitSuite$$anonfun$1.apply(StandaloneRestSubmitSuite.scala:54)
at org.apache.spark.deploy.rest.StandaloneRestSubmitSuite$$anonfun$1.apply(StandaloneRestSubmitSuite.scala:54)
at org.scalatest.Transformer$$anonfun$apply$1.apply$mcV$sp(Transformer.scala:22)
...
Cause: java.lang.NullPointerException:
at java.util.Properties$LineReader.readLine(Properties.java:434)
at java.util.Properties.load0(Properties.java:353)
at java.util.Properties.load(Properties.java:341)
at org.apache.spark.package$SparkBuildInfo$.liftedTree1$1(package.scala:64)
at org.apache.spark.package$SparkBuildInfo$.(package.scala:61)
at org.apache.spark.package$SparkBuildInfo$.(package.scala)
at org.apache.spark.package$.(package.scala:91)
at org.apache.spark.package$.(package.scala)
at org.apache.spark.deploy.rest.RestSubmissionClient.constructSubmitRequest(RestSubmissionClient.scala:179)
at org.apache.spark.deploy.rest.StandaloneRestSubmitSuite$$anonfun$1.apply$mcV$sp(StandaloneRestSubmitSuite.scala:58)
...

[HyukjinKwon]

@guoxiaolongzte, Let's ask a question to mailing list. Up to my knowledge, we should build first before running tests properly and maybe the errors are related with it.