Uh oh!
There was an error while loading. Please reload this page.
[SPARK-17512][Core] Avoid formatting to python path for yarn and mesos cluster mode - #15137
[SPARK-17512][Core] Avoid formatting to python path for yarn and mesos cluster mode#15137jerryshao wants to merge 2 commits into
Conversation
SparkQA
commented
Sep 18, 2016
Test build #65557 has finished for PR 15137 at commit
|
Good catch. I'm merging this into master and 2.0. Thanks. |
…s cluster mode ## What changes were proposed in this pull request? Yarn and mesos cluster mode support remote python path (HDFS/S3 scheme) by their own mechanism, it is not necessary to check and format the python when running on these modes. This is a potential regression compared to 1.6, so here propose to fix it. ## How was this patch tested? Unit test to verify SparkSubmit arguments, also with local cluster verification. Because of lack of `MiniDFSCluster` support in Spark unit test, there's no integration test added. Author: jerryshao <sshao@hortonworks.com> Closes#15137 from jerryshao/SPARK-17512. (cherry picked from commit 8c3ee2b) Signed-off-by: Andrew Or <andrewor14@gmail.com>
andrewor14
commented
Sep 21, 2016
I've merged it. One more thing, would you mind correcting the comment in |
jerryshao
commented
Sep 22, 2016
Try to think in another way from |
andrewor14
commented
Sep 22, 2016
Got it. I think back then when I wrote that comment we still haven't supported cluster mode with python yet. It's just a little confusing if we're reading that comment in isolation. |
steveloughran
commented
Oct 3, 2016
I see this in master; but the JIRA associated with the PR is still opened & unversioned. Which version did it make it into? |
srowen
commented
Oct 3, 2016
From the commits, it's in 2.0.1 and 2.1.0. Looks like the JIRA just wasn't resolved (I'll do that). |
What changes were proposed in this pull request?
Yarn and mesos cluster mode support remote python path (HDFS/S3 scheme) by their own mechanism, it is not necessary to check and format the python when running on these modes. This is a potential regression compared to 1.6, so here propose to fix it.
How was this patch tested?
Unit test to verify SparkSubmit arguments, also with local cluster verification. Because of lack of
MiniDFSClustersupport in Spark unit test, there's no integration test added.