Uh oh!
There was an error while loading. Please reload this page.
Skip building R vignettes if Spark is not built - #15200
Conversation
shivaram
commented
Sep 22, 2016
The only downside of this is that we won't be uploading our vignette to the website. I think this is fine -- Any thoughts @junyangq@felixcheung cc @rxin |
SparkQA
commented
Sep 22, 2016
Test build #65778 has finished for PR 15200 at commit
|
rxin
commented
Sep 22, 2016
I'm going to merge this in master/branch-2.0 because I need this to cut an rc. |
## What changes were proposed in this pull request? When we build the docs separately we don't have the JAR files from the Spark build in the same tree. As the SparkR vignettes need to launch a SparkContext to be built, we skip building them if JAR files don't exist ## How was this patch tested? To test this we can run the following: ``` build/mvn -DskipTests -Psparkr clean ./R/create-docs.sh ``` You should see a line `Skipping R vignettes as Spark JARs not found` at the end Author: Shivaram Venkataraman <shivaram@cs.berkeley.edu> Closes#15200 from shivaram/sparkr-vignette-skip. (cherry picked from commit 9f24a17) Signed-off-by: Reynold Xin <rxin@databricks.com>
felixcheung
commented
Sep 23, 2016
we could hand write the result instead of running test/Spark to generate the vignettes? maybe we should add vignettes to profile |
shivaram
commented
Sep 23, 2016
Yeah - so I'm thinking we should just auto-generate this and check in the html file in git. Its not that big. When somebody updates the vignette we need to remind them to regenerate it though as a part of the PR ? |
felixcheung
commented
Sep 23, 2016
if it's part of the |
What changes were proposed in this pull request?
When we build the docs separately we don't have the JAR files from the Spark build in
the same tree. As the SparkR vignettes need to launch a SparkContext to be built, we skip building them if JAR files don't exist
How was this patch tested?
To test this we can run the following:
You should see a line
Skipping R vignettes as Spark JARs not foundat the end