Skip to content

[SPARK-17778][Tests]Mock SparkContext to reduce memory usage of BlockManagerSuite - #15350

Closed
zsxwing wants to merge 2 commits into
apache:masterfrom
zsxwing:SPARK-17778
Closed

[SPARK-17778][Tests]Mock SparkContext to reduce memory usage of BlockManagerSuite#15350
zsxwing wants to merge 2 commits into
apache:masterfrom
zsxwing:SPARK-17778

Conversation

@zsxwing

@zsxwingzsxwing commented Oct 4, 2016

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Mock SparkContext to reduce memory usage of BlockManagerSuite

How was this patch tested?

Jenkins

@zsxwing

zsxwing commented Oct 4, 2016

Copy link
Copy Markdown
MemberAuthor

/cc @markhamstra could you try this patch, please?

@SparkQA

SparkQA commented Oct 4, 2016

Copy link
Copy Markdown

Test build #66336 has finished for PR 15350 at commit a8201b9.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing

zsxwing commented Oct 4, 2016

Copy link
Copy Markdown
MemberAuthor

retest this please

@SparkQA

SparkQA commented Oct 5, 2016

Copy link
Copy Markdown

Test build #66342 has finished for PR 15350 at commit a8201b9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

rxin
rxin reviewed Oct 5, 2016
View reviewed changes
Comment threadcore/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala
conf.set("spark.driver.port", rpcEnv.address.port.toString)

sc = new SparkContext("local", "test", conf)
sc = mock(classOf[SparkContext])

@rxinrxinOct 5, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to comment on the reason for this change too

@zsxwingzsxwingOct 5, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to comment on the reason for this change too

Added

@srowen

srowen commented Oct 5, 2016

Copy link
Copy Markdown
Member

Does this not defeat some of the purpose of testing, if it isn't using an actual SparkContext?

@andrewor14

andrewor14 commented Oct 5, 2016

Copy link
Copy Markdown
Contributor

I think that's OK. This is supposed to be a unit test for the BlockManager, not how BlockManager interacts with the rest of the system. LGTM

@zsxwing

zsxwing commented Oct 5, 2016

Copy link
Copy Markdown
MemberAuthor

Does this not defeat some of the purpose of testing, if it isn't using an actual SparkContext?

The only reason we need to create a SparkContext is to initialize LiveListenerBus. There was no SparkContext in this file before we added a configuration to LiveListenerBus.

@markhamstra

markhamstra commented Oct 5, 2016

Copy link
Copy Markdown
Contributor

@zsxwingbuild/mvn -U -Pyarn -Phadoop-2.7 -Pkinesis-asl -Phive -Phive-thriftserver -Dpyspark -Dsparkr test completely succeeded on one of my machines where it was previously failing.

@SparkQA

SparkQA commented Oct 5, 2016

Copy link
Copy Markdown

Test build #66399 has finished for PR 15350 at commit 6a27d2a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing

zsxwing commented Oct 5, 2016

Copy link
Copy Markdown
MemberAuthor

Thanks! Merging to master and 2.0

asfgit pushed a commit that referenced this pull request Oct 5, 2016
@zsxwing
[SPARK-17778][TESTS] Mock SparkContext to reduce memory usage of Bloc…
b8df2e5
…kManagerSuite
## What changes were proposed in this pull request?
Mock SparkContext to reduce memory usage of BlockManagerSuite
## How was this patch tested?
Jenkins
Author: Shixiong Zhu <shixiong@databricks.com>
Closes#15350 from zsxwing/SPARK-17778.
(cherry picked from commit 221b418)
Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
@asfgitasfgit closed this in 221b418Oct 5, 2016
@zsxwing
zsxwing deleted the SPARK-17778 branch October 5, 2016 21:58
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
@zsxwing@uzadude
[SPARK-17778][TESTS] Mock SparkContext to reduce memory usage of Bloc…
4735bc1
…kManagerSuite
## What changes were proposed in this pull request?
Mock SparkContext to reduce memory usage of BlockManagerSuite
## How was this patch tested?
Jenkins
Author: Shixiong Zhu <shixiong@databricks.com>
Closesapache#15350 from zsxwing/SPARK-17778.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rxinrxinrxin left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zsxwing@SparkQA@srowen@andrewor14@markhamstra@rxin