Uh oh!
There was an error while loading. Please reload this page.
[SPARK-18103] [SQL] Rename *FileCatalog to *FileIndex - #15634
Closed
ericl wants to merge 5 commits into
Closed
Conversation
SparkQA
commented
Oct 26, 2016
Test build #67544 has finished for PR 15634 at commit
|
marmbrus
commented
Oct 26, 2016
Contributor
This is okay, but note that "Provider" is equally overloaded in the Data Source API. |
ericl
commented
Oct 26, 2016
ContributorAuthor
Hmm, any other suggestions? |
rxin
commented
Oct 26, 2016
Contributor
FileLister? FileListing? |
ContributorAuthor
How about |
ericl
commented
Oct 27, 2016
ContributorAuthor
Concretely, I propose renaming I think this would make the differences between these classes more clear. Previously, the name was only loosely tied with their behavior. |
rxin
commented
Oct 28, 2016
Contributor
FileIndex sounds good to me. I wouldn't call it "Metastore" though, since that is a Hive specific term. I'd call it Catalog. |
ericlforce-pushed
the
rename-file-provider
branch
from
October 28, 2016 18:37
0776537 to
b6654f1CompareSparkQA
commented
Oct 28, 2016
Test build #67717 has finished for PR 15634 at commit
|
SparkQA
commented
Oct 28, 2016
Test build #67718 has finished for PR 15634 at commit
|
rxin
commented
Oct 29, 2016
Contributor
LGTM pending tests. |
SparkQA
commented
Oct 29, 2016
Test build #67747 has finished for PR 15634 at commit
|
rxin
commented
Oct 30, 2016
Contributor
Merging in master. |
robert3005 pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
## What changes were proposed in this pull request? To reduce the number of components in SQL named *Catalog, rename *FileCatalog to *FileIndex. A FileIndex is responsible for returning the list of partitions / files to scan given a filtering expression. ``` TableFileCatalog => CatalogFileIndex FileCatalog => FileIndex ListingFileCatalog => InMemoryFileIndex MetadataLogFileCatalog => MetadataLogFileIndex PrunedTableFileCatalog => PrunedInMemoryFileIndex ``` cc yhuai marmbrus ## How was this patch tested? N/A Author: Eric Liang <ekl@databricks.com> Author: Eric Liang <ekhliang@gmail.com> Closesapache#15634 from ericl/rename-file-provider.
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Nov 1, 2016
…to `MetadataLogFileIndex` ## What changes were proposed in this pull request? This is a follow-up to apache#15634. ## How was this patch tested? N/A Author: Liwei Lin <lwlin7@gmail.com> Closesapache#15712 from lw-lin/18103.
uzadude pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? To reduce the number of components in SQL named *Catalog, rename *FileCatalog to *FileIndex. A FileIndex is responsible for returning the list of partitions / files to scan given a filtering expression. ``` TableFileCatalog => CatalogFileIndex FileCatalog => FileIndex ListingFileCatalog => InMemoryFileIndex MetadataLogFileCatalog => MetadataLogFileIndex PrunedTableFileCatalog => PrunedInMemoryFileIndex ``` cc yhuai marmbrus ## How was this patch tested? N/A Author: Eric Liang <ekl@databricks.com> Author: Eric Liang <ekhliang@gmail.com> Closesapache#15634 from ericl/rename-file-provider.
uzadude pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…to `MetadataLogFileIndex` ## What changes were proposed in this pull request? This is a follow-up to apache#15634. ## How was this patch tested? N/A Author: Liwei Lin <lwlin7@gmail.com> Closesapache#15712 from lw-lin/18103.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To reduce the number of components in SQL named *Catalog, rename *FileCatalog to *FileIndex. A FileIndex is responsible for returning the list of partitions / files to scan given a filtering expression.
cc @yhuai@marmbrus
How was this patch tested?
N/A