Skip to content

[SPARK-18235][ML] ml.ALSModel function parity: ALSModel should support recommendforAll - #15762

Closed
hhbyyh wants to merge 2 commits into
apache:masterfrom
hhbyyh:alsrecommend
Closed

[SPARK-18235][ML] ml.ALSModel function parity: ALSModel should support recommendforAll#15762
hhbyyh wants to merge 2 commits into
apache:masterfrom
hhbyyh:alsrecommend

Conversation

@hhbyyh

@hhbyyhhhbyyh commented Nov 4, 2016

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

jira: https://issues.apache.org/jira/browse/SPARK-18235
For function parity with MatrixFactorizationModel, ALS model should support API:
recommendUsersForProducts
recommendProductsForUsers

I try to avoid code duplication by invoking the MLlib MatrixFactorizationModel directly.

How was this patch tested?

new test case

@hhbyyh

Copy link
Copy Markdown
ContributorAuthor

@SparkQA

Copy link
Copy Markdown

Test build #68098 has finished for PR 15762 at commit 4e830f8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sethah

Copy link
Copy Markdown
Contributor

Looks like a duplicate of #12574 ?

@hhbyyhhhbyyh closed this Nov 4, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@hhbyyh@SparkQA@sethah@YY-OnCall