Uh oh!
There was an error while loading. Please reload this page.
[SPARK-18286][ML] Add Scala/Java examples for MinHash and RandomProjection - #15787
[SPARK-18286][ML] Add Scala/Java examples for MinHash and RandomProjection#15787jiayue-zhang wants to merge 2 commits into
Conversation
yanboliang
commented
Nov 7, 2016
@jkbradley@MLnick@srowen Could you help to add @bravo-zhang to whitelist? Thanks. |
srowen
commented
Nov 7, 2016
Jenkins add to whitelist |
srowen
commented
Nov 7, 2016
Looking good, excepting that there are no python examples? |
SparkQA
commented
Nov 7, 2016
Test build #68271 has finished for PR 15787 at commit
|
srowen
commented
Nov 7, 2016
OK, to keep this straight: let's remove "Python" from this JIRA and PR and get it in. The Python API JIRA, SPARK-18010, should also add examples if possible. However this seems to overlap with SPARK-18081. I think this needs to coordinate what examples are being added. |
SparkQA
commented
Nov 7, 2016
Test build #68282 has finished for PR 15787 at commit
|
srowen
left a comment
There was a problem hiding this comment.
It looks OK to me, though given how much is being discussed in SPARK-18081 it might even be better to make sure this is consistent with its outcome, which also includes examples.
jkbradley
commented
Nov 10, 2016
Linking [https://issues.apache.org/jira/browse/SPARK-18392] since it will alter the public API for LSH |
jiayue-zhang
commented
Dec 4, 2016
This PR can be closed since #15795 has merged |
jkbradley
commented
Dec 8, 2016
Ah, thank you @bravo-zhang ! |
What changes were proposed in this pull request?
Add Scala/Java/Python examples for MinHash and RandomProjection
How was this patch tested?
./bin/run-example ml.MinHashExample./bin/run-example ml.JavaMinHashExample./bin/run-example ml.RandomProjectionExample./bin/run-example ml.JavaRandomProjectionExample