Uh oh!
There was an error while loading. Please reload this page.
[SPARK-18338][SQL][test-maven] Fix test case initialization order under Maven builds - #15802
[SPARK-18338][SQL][test-maven] Fix test case initialization order under Maven builds#15802liancheng wants to merge 1 commit into
Conversation
SparkQA
commented
Nov 8, 2016
Test build #68306 has finished for PR 15802 at commit
|
yhuai
commented
Nov 8, 2016
Seems it does not work with sbt? |
zsxwing
commented
Nov 8, 2016
Could you add |
zsxwing
commented
Nov 8, 2016
I saw the same |
liancheng
commented
Nov 8, 2016
@cloud-fan already reported the OOM issue. I'm trying to reproduce it locally. Added the |
liancheng
commented
Nov 8, 2016
retest this please |
SparkQA
commented
Nov 8, 2016
Test build #68355 has finished for PR 15802 at commit
|
liancheng
commented
Nov 8, 2016
retest this please. |
liancheng
commented
Nov 8, 2016
The last build failure was caused by an irrelevant flaky test. BTW, I've reproduced the OOM issue locally by running |
SparkQA
commented
Nov 9, 2016
Test build #68365 has finished for PR 15802 at commit
|
yhuai
commented
Nov 9, 2016
I am going to merge this to fix maven build. |
…er Maven builds ## What changes were proposed in this pull request? Test case initialization order under Maven and SBT are different. Maven always creates instances of all test cases and then run them all together. This fails `ObjectHashAggregateSuite` because the randomized test cases there register a temporary Hive function right before creating a test case, and can be cleared while initializing other successive test cases. In SBT, this is fine since the created test case is executed immediately after creating the temporary function. To fix this issue, we should put initialization/destruction code into `beforeAll()` and `afterAll()`. ## How was this patch tested? Existing tests. Author: Cheng Lian <lian@databricks.com> Closesapache#15802 from liancheng/fix-flaky-object-hash-agg-suite.
What changes were proposed in this pull request?
Test case initialization order under Maven and SBT are different. Maven always creates instances of all test cases and then run them all together.
This fails
ObjectHashAggregateSuitebecause the randomized test cases there register a temporary Hive function right before creating a test case, and can be cleared while initializing other successive test cases. In SBT, this is fine since the created test case is executed immediately after creating the temporary function.To fix this issue, we should put initialization/destruction code into
beforeAll()andafterAll().How was this patch tested?
Existing tests.