Skip to content

[SPARK-18376][SQL] Skip subexpression elimination for conditional expressions - #15824

Closed
viirya wants to merge 1 commit into
apache:masterfrom
viirya:no-subexpr-eliminate-conditionexpr
Closed

[SPARK-18376][SQL] Skip subexpression elimination for conditional expressions#15824
viirya wants to merge 1 commit into
apache:masterfrom
viirya:no-subexpr-eliminate-conditionexpr

Conversation

@viirya

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

As per discussion at #15807, we should disallow subexpression elimination for expressions wrapped in conditional expressions such as If.

How was this patch tested?

Jenkins tests.

Please review https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark before opening a pull request.

@viirya

Copy link
Copy Markdown
MemberAuthor

cc @cloud-fan@kiszk

@viiryaviirya changed the title [SQL] Skip subexpression elimination for conditional expressions[SPARK-18376][SQL] Skip subexpression elimination for conditional expressionsNov 9, 2016
@SparkQA

Copy link
Copy Markdown

Test build #68389 has finished for PR 15824 at commit 548e45f.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya

Copy link
Copy Markdown
MemberAuthor

retest this please.

@SparkQA

Copy link
Copy Markdown

Test build #68393 has finished for PR 15824 at commit 548e45f.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya

Copy link
Copy Markdown
MemberAuthor

retest this please.

@SparkQA

Copy link
Copy Markdown

Test build #68394 has finished for PR 15824 at commit 548e45f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya

Copy link
Copy Markdown
MemberAuthor

Close this for now because we might prefer other solution.

@viiryaviirya closed this Nov 9, 2016
@viirya
viirya deleted the no-subexpr-eliminate-conditionexpr branch December 27, 2023 18:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@viirya@SparkQA