Uh oh!
There was an error while loading. Please reload this page.
[SPARK-18134][SQL] Comparable MapTypes [POC] - #15970
Conversation
hvanhovell
commented
Nov 22, 2016
cc @cloud-fan we discussed something like this earlier today |
SparkQA
commented
Nov 22, 2016
Test build #68968 has finished for PR 15970 at commit
|
SparkQA
commented
Nov 22, 2016
Test build #69003 has finished for PR 15970 at commit
|
# Conflicts: # sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala # sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala
SparkQA
commented
Nov 22, 2016
Test build #69023 has finished for PR 15970 at commit
|
SparkQA
commented
Nov 24, 2016
Test build #69136 has finished for PR 15970 at commit
|
SparkQA
commented
Nov 25, 2016
Test build #69141 has finished for PR 15970 at commit
|
albertferras
commented
Apr 12, 2017
Any update on this? |
gatorsmile
commented
Jun 16, 2017
cc @hvanhovell |
janewangfb
commented
Aug 9, 2017
Is there any updates on this PR? This feature is quite useful to us. |
jinxing64
commented
Sep 11, 2017
@hvanhovell Are you still working on this? I think this is feature is useful :) |
maropu
commented
Jul 23, 2018
@hvanhovell We still need to keep this pr open? Either way, we need rework based on this pr. If so, can you close this for now? |
SparkQA
commented
Oct 22, 2018
Test build #97829 has started for PR 15970 at commit |
SparkQA
commented
Oct 22, 2018
Test build #97847 has started for PR 15970 at commit |
SparkQA
commented
Oct 22, 2018
Test build #97859 has started for PR 15970 at commit |
AmplabJenkins
commented
Oct 22, 2018
Build finished. Test FAILed. |
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
What changes were proposed in this pull request?
This is a small POC to see if we can make MapType orderable, and thus usable in aggregates and joins. The key idea in this PR is that there is a difference between an unordered and an ordered map (an ordered map is can be compared), and that
orderedis a property ofMapType.A map can be converted from an unordered map to an ordered map by injecting a
SortMapexpression. The analyzer will injectSortMapexpressions whenever we use a map in a binary comparison and when we use it in an aggregate. Note that theSortMapexpression is far from optimized, it should however perform reasonable.How was this patch tested?
No tests yet. This will probably fail tests.