Uh oh!
There was an error while loading. Please reload this page.
[SPARK-18625][ML] OneVsRestModel should support setFeaturesCol and setPredictionCol - #16059
[SPARK-18625][ML] OneVsRestModel should support setFeaturesCol and setPredictionCol#16059zhengruifeng wants to merge 5 commits into
Conversation
srowen
commented
Nov 29, 2016
Is this not the same as #15957 but for a different class? |
zhengruifeng
commented
Nov 29, 2016
@srowen Excepet that OvR is a meta algorithm, and we need to update the behavior of base models. |
srowen
commented
Nov 29, 2016
OK, should it not have been added in the other PR? I want to push back on adding logical changes piecemeal. I understand sometimes it only becomes clear later that further changes are needed, but if it happens regularly or seems avoidable it becomes a problem. |
zhengruifeng
commented
Nov 29, 2016
I understand your opinion that we should make same update in a batch. But I just find this issue this night... |
SparkQA
commented
Nov 29, 2016
Test build #69322 has finished for PR 16059 at commit
|
srowen
commented
Dec 2, 2016
CC @yanboliang ? |
yanboliang
commented
Dec 4, 2016
@srowen Thanks for cc me, I'm having a look now. |
yanboliang
left a comment
There was a problem hiding this comment.
Looks good overall, except some minor comments. Thanks!
There was a problem hiding this comment.
It's not necessary to setPredictionCol here, since the prediction column of each base binary classifier is ignored during the transformation. The predictionCol of OneVsRestModel was set at L198.
There was a problem hiding this comment.
Minor: assert(outputFields === Set("y", "fea", "pred"))
4a6ecab to
61dcd51Comparezhengruifeng
commented
Dec 5, 2016
@yanboliang Updated. Thanks for reviewing. |
SparkQA
commented
Dec 5, 2016
Test build #69657 has finished for PR 16059 at commit
|
yanboliang
commented
Dec 5, 2016
LGTM, merged into master and branch-2.1. Thanks for all. |
…tPredictionCol ## What changes were proposed in this pull request? add `setFeaturesCol` and `setPredictionCol` for `OneVsRestModel` ## How was this patch tested? added tests Author: Zheng RuiFeng <ruifengz@foxmail.com> Closes#16059 from zhengruifeng/ovrm_setCol. (cherry picked from commit bdfe7f6) Signed-off-by: Yanbo Liang <ybliang8@gmail.com>
…tPredictionCol ## What changes were proposed in this pull request? add `setFeaturesCol` and `setPredictionCol` for `OneVsRestModel` ## How was this patch tested? added tests Author: Zheng RuiFeng <ruifengz@foxmail.com> Closesapache#16059 from zhengruifeng/ovrm_setCol.
…tPredictionCol ## What changes were proposed in this pull request? add `setFeaturesCol` and `setPredictionCol` for `OneVsRestModel` ## How was this patch tested? added tests Author: Zheng RuiFeng <ruifengz@foxmail.com> Closesapache#16059 from zhengruifeng/ovrm_setCol.
What changes were proposed in this pull request?
add
setFeaturesColandsetPredictionColforOneVsRestModelHow was this patch tested?
added tests