Uh oh!
There was an error while loading. Please reload this page.
[SPARK-18714][SQL] Add a simple time function to SparkSession - #16140
[SPARK-18714][SQL] Add a simple time function to SparkSession#16140rxin wants to merge 1 commit into
Conversation
rxin
commented
Dec 5, 2016
cc @marmbrus |
SparkQA
commented
Dec 5, 2016
Test build #69662 has started for PR 16140 at commit |
dongjoon-hyun
commented
Dec 5, 2016
Retest this please |
rxin
commented
Dec 5, 2016
It's ok no need to retest. The change is fine. |
dongjoon-hyun
commented
Dec 5, 2016
I see. BTW, @rxin . Do we need |
rxin
commented
Dec 5, 2016
That's much more difficult to type though. |
dongjoon-hyun
commented
Dec 5, 2016
True. Never mind. I just thought we were able to use like the following. |
SparkQA
commented
Dec 5, 2016
Test build #69664 has finished for PR 16140 at commit
|
srowen
commented
Dec 5, 2016
shrug It seems pretty unrelated to SparkSession. I get that it's a convenience method but something Spark really needs to expose as an API method? |
rxin
commented
Dec 6, 2016
The cost to maintain this seems very small though, and I'd definitely use it all the time in the repl. In Databricks this is not an issue since the environment always appends the time, but I really miss this in the repl. |
hvanhovell
commented
Dec 6, 2016
LGTM - merging to master/2.1. Thanks! |
## What changes were proposed in this pull request?
Many Spark developers often want to test the runtime of some function in interactive debugging and testing. This patch adds a simple time function to SparkSession:
```
scala> spark.time { spark.range(1000).count() }
Time taken: 77 ms
res1: Long = 1000
```
## How was this patch tested?
I tested this interactively in spark-shell.
Author: Reynold Xin <rxin@databricks.com>
Closes#16140 from rxin/SPARK-18714.
(cherry picked from commit cb1f10b)
Signed-off-by: Herman van Hovell <hvanhovell@databricks.com>## What changes were proposed in this pull request?
Many Spark developers often want to test the runtime of some function in interactive debugging and testing. This patch adds a simple time function to SparkSession:
```
scala> spark.time { spark.range(1000).count() }
Time taken: 77 ms
res1: Long = 1000
```
## How was this patch tested?
I tested this interactively in spark-shell.
Author: Reynold Xin <rxin@databricks.com>
Closesapache#16140 from rxin/SPARK-18714.## What changes were proposed in this pull request?
Many Spark developers often want to test the runtime of some function in interactive debugging and testing. This patch adds a simple time function to SparkSession:
```
scala> spark.time { spark.range(1000).count() }
Time taken: 77 ms
res1: Long = 1000
```
## How was this patch tested?
I tested this interactively in spark-shell.
Author: Reynold Xin <rxin@databricks.com>
Closesapache#16140 from rxin/SPARK-18714.
What changes were proposed in this pull request?
Many Spark developers often want to test the runtime of some function in interactive debugging and testing. This patch adds a simple time function to SparkSession:
How was this patch tested?
I tested this interactively in spark-shell.