Uh oh!
There was an error while loading. Please reload this page.
[SPARK-18729][SS]Move DataFrame.collect out of synchronized block in MemorySink - #16162
Closed
zsxwing wants to merge 1 commit into
Closed
[SPARK-18729][SS]Move DataFrame.collect out of synchronized block in MemorySink#16162zsxwing wants to merge 1 commit into
zsxwing wants to merge 1 commit into
Conversation
tdas
commented
Dec 6, 2016
Contributor
LGTM. |
brkyvz
commented
Dec 6, 2016
Contributor
Thanks @zsxwing LGTM2! |
SparkQA
commented
Dec 6, 2016
Test build #69699 has finished for PR 16162 at commit
|
tdas
commented
Dec 6, 2016
Contributor
Merging to master and 2.1 |
asfgit pushed a commit
that referenced
this pull request
Dec 6, 2016
… MemorySink ## What changes were proposed in this pull request? Move DataFrame.collect out of synchronized block so that we can query content in MemorySink when `DataFrame.collect` is running. ## How was this patch tested? Jenkins Author: Shixiong Zhu <shixiong@databricks.com> Closes#16162 from zsxwing/SPARK-18729. (cherry picked from commit 1b2785c) Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
robert3005 pushed a commit
to palantir/spark
that referenced
this pull request
Dec 15, 2016
… MemorySink ## What changes were proposed in this pull request? Move DataFrame.collect out of synchronized block so that we can query content in MemorySink when `DataFrame.collect` is running. ## How was this patch tested? Jenkins Author: Shixiong Zhu <shixiong@databricks.com> Closesapache#16162 from zsxwing/SPARK-18729.
uzadude pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
… MemorySink ## What changes were proposed in this pull request? Move DataFrame.collect out of synchronized block so that we can query content in MemorySink when `DataFrame.collect` is running. ## How was this patch tested? Jenkins Author: Shixiong Zhu <shixiong@databricks.com> Closesapache#16162 from zsxwing/SPARK-18729.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move DataFrame.collect out of synchronized block so that we can query content in MemorySink when
DataFrame.collectis running.How was this patch tested?
Jenkins