Skip to content

[SPARK-18762][WEBUI] Web UI should be http:4040 instead of https:4040 - #16190

Closed
sarutak wants to merge 2 commits into
apache:masterfrom
sarutak:SPARK-18761
Closed

[SPARK-18762][WEBUI] Web UI should be http:4040 instead of https:4040#16190
sarutak wants to merge 2 commits into
apache:masterfrom
sarutak:SPARK-18761

Conversation

@sarutak

@sarutaksarutak commented Dec 7, 2016•
edited
Loading

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

When SSL is enabled, the Spark shell shows:

Spark context Web UI available at https://192.168.99.1:4040

This is wrong because 4040 is http, not https. It redirects to the https port.
More importantly, this introduces several broken links in the UI. For example, in the master UI, the worker link is https:8081 instead of http:8081 or https:8481.

CC: @mengxr@liancheng

I manually tested accessing by accessing MasterPage, WorkerPage and HistoryServer with SSL enabled.

@sarutaksarutak changed the title [SPARK-18761][WEBUI] Web UI should be http:4040 instead of https:4040[SPARK-18761][WEBUI][WIP] Web UI should be http:4040 instead of https:4040Dec 7, 2016
@SparkQA

SparkQA commented Dec 7, 2016

Copy link
Copy Markdown

Test build #69781 has started for PR 16190 at commit 4518010.

@viirya

viirya commented Dec 7, 2016

Copy link
Copy Markdown
Member

I think the jira number should be SPARK-18762, instead of SPARK-18761.

@sarutaksarutak changed the title [SPARK-18761][WEBUI][WIP] Web UI should be http:4040 instead of https:4040[SPARK-18762][WEBUI][WIP] Web UI should be http:4040 instead of https:4040Dec 7, 2016
@sarutak

sarutak commented Dec 7, 2016

Copy link
Copy Markdown
MemberAuthor

@viirya Thanks! I've fixed it.

@sarutak

sarutak commented Dec 7, 2016

Copy link
Copy Markdown
MemberAuthor

I've confirmed I can access MasterPage and WorkerPage with SSL enabled.
ssl0
ssl1

During the investigation, I've noticed one link from MasterPage to WorkerPage was broken before #15611. Maybe, 43f1d59 broke. I've also fixed it.

@sarutak

sarutak commented Dec 7, 2016

Copy link
Copy Markdown
MemberAuthor

cc: @mengxr

@sarutak

sarutak commented Dec 7, 2016

Copy link
Copy Markdown
MemberAuthor

Of course, HistoryServer works with SSL enabled.

ssl2

@sarutaksarutak changed the title [SPARK-18762][WEBUI][WIP] Web UI should be http:4040 instead of https:4040[SPARK-18762][WEBUI] Web UI should be http:4040 instead of https:4040Dec 7, 2016
@sarutak

sarutak commented Dec 7, 2016

Copy link
Copy Markdown
MemberAuthor

Also, Spark Shell says as follows.

Spark context Web UI available at http://192.168.1.1:4040

@SparkQA

SparkQA commented Dec 7, 2016

Copy link
Copy Markdown

Test build #69790 has finished for PR 16190 at commit 66e0edf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr

mengxr commented Dec 7, 2016

Copy link
Copy Markdown
Contributor

@sarutak Do you know why we needed this change to fix ssl-enabled history server in #15611?

@vanzin

vanzin commented Dec 7, 2016

Copy link
Copy Markdown
Contributor

@mengxr that change is actually incorrect and shouldn't have been merged. (The test changes in the same patch are ok though.)

This one LGTM.

@vanzin

vanzin commented Dec 7, 2016

Copy link
Copy Markdown
Contributor

merging to master / 2.1

@vanzin

vanzin commented Dec 7, 2016

Copy link
Copy Markdown
Contributor

Hmm, looks like the original change is in branch-2.0 also, let me try to merge there too.

@asfgitasfgit closed this in bb94f61Dec 7, 2016
asfgit pushed a commit that referenced this pull request Dec 7, 2016
@sarutakMarcelo Vanzin
[SPARK-18762][WEBUI] Web UI should be http:4040 instead of https:4040
76e1f16
## What changes were proposed in this pull request?
When SSL is enabled, the Spark shell shows:
```
Spark context Web UI available at https://192.168.99.1:4040
```
This is wrong because 4040 is http, not https. It redirects to the https port.
More importantly, this introduces several broken links in the UI. For example, in the master UI, the worker link is https:8081 instead of http:8081 or https:8481.
CC: mengxr liancheng
I manually tested accessing by accessing MasterPage, WorkerPage and HistoryServer with SSL enabled.
Author: sarutak <sarutak@oss.nttdata.co.jp>
Closes#16190 from sarutak/SPARK-18761.
(cherry picked from commit bb94f61)
Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
@vanzin

vanzin commented Dec 7, 2016

Copy link
Copy Markdown
Contributor

Merged to 2.0 also.

asfgit pushed a commit that referenced this pull request Dec 7, 2016
@sarutakMarcelo Vanzin
[SPARK-18762][WEBUI] Web UI should be http:4040 instead of https:4040
44df6d2
## What changes were proposed in this pull request?
When SSL is enabled, the Spark shell shows:
```
Spark context Web UI available at https://192.168.99.1:4040
```
This is wrong because 4040 is http, not https. It redirects to the https port.
More importantly, this introduces several broken links in the UI. For example, in the master UI, the worker link is https:8081 instead of http:8081 or https:8481.
CC: mengxr liancheng
I manually tested accessing by accessing MasterPage, WorkerPage and HistoryServer with SSL enabled.
Author: sarutak <sarutak@oss.nttdata.co.jp>
Closes#16190 from sarutak/SPARK-18761.
(cherry picked from commit bb94f61)
Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
@mengxr

mengxr commented Dec 7, 2016

Copy link
Copy Markdown
Contributor

@sarutak Thanks for the quick fix!

robert3005 pushed a commit to palantir/spark that referenced this pull request Dec 15, 2016
@sarutakRobert Kruszewski
[SPARK-18762][WEBUI] Web UI should be http:4040 instead of https:4040
a29f107
## What changes were proposed in this pull request?
When SSL is enabled, the Spark shell shows:
```
Spark context Web UI available at https://192.168.99.1:4040
```
This is wrong because 4040 is http, not https. It redirects to the https port.
More importantly, this introduces several broken links in the UI. For example, in the master UI, the worker link is https:8081 instead of http:8081 or https:8481.
CC: mengxr liancheng
I manually tested accessing by accessing MasterPage, WorkerPage and HistoryServer with SSL enabled.
Author: sarutak <sarutak@oss.nttdata.co.jp>
Closesapache#16190 from sarutak/SPARK-18761.
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
@sarutak@uzadude
[SPARK-18762][WEBUI] Web UI should be http:4040 instead of https:4040
36b40ff
## What changes were proposed in this pull request?
When SSL is enabled, the Spark shell shows:
```
Spark context Web UI available at https://192.168.99.1:4040
```
This is wrong because 4040 is http, not https. It redirects to the https port.
More importantly, this introduces several broken links in the UI. For example, in the master UI, the worker link is https:8081 instead of http:8081 or https:8481.
CC: mengxr liancheng
I manually tested accessing by accessing MasterPage, WorkerPage and HistoryServer with SSL enabled.
Author: sarutak <sarutak@oss.nttdata.co.jp>
Closesapache#16190 from sarutak/SPARK-18761.
@sarutak
sarutak deleted the SPARK-18761 branch June 4, 2021 20:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sarutak@SparkQA@viirya@mengxr@vanzin