[SPARK-18895][TESTS] Fix resource-closing-related and path-related test failures in identified ones on Windows by HyukjinKwon · Pull Request #16305 · apache/spark

HyukjinKwon · 2016-12-16T07:03:25Z

What changes were proposed in this pull request?

There are several tests failing due to resource-closing-related and path-related problems on Windows as below.

RPackageUtilsSuite:

- build an R package from a jar end to end *** FAILED *** (1 second, 625 milliseconds)
java.io.IOException: Unable to delete file: C:\projects\spark\target\tmp\1481729427517-0\a\dep2\d\dep2-d.jar
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2279)
at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1535)
- faulty R package shows documentation *** FAILED *** (359 milliseconds)
java.io.IOException: Unable to delete file: C:\projects\spark\target\tmp\1481729428970-0\dep1-c.jar
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2279)
at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1535)
- SparkR zipping works properly *** FAILED *** (47 milliseconds)
java.util.regex.PatternSyntaxException: Unknown character property name {r} near index 4
C:\projects\spark\target\tmp\1481729429282-0
^
at java.util.regex.Pattern.error(Pattern.java:1955)
at java.util.regex.Pattern.charPropertyNodeFor(Pattern.java:2781)

InputOutputMetricsSuite:

- input metrics for old hadoop with coalesce *** FAILED *** (240 milliseconds)
java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored
at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277)
at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202)
at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252)
- input metrics with cache and coalesce *** FAILED *** (109 milliseconds)
java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored
at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277)
at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202)
at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252)
- input metrics for new Hadoop API with coalesce *** FAILED *** (0 milliseconds)
java.lang.IllegalArgumentException: Wrong FS: file://C:\projects\spark\target\tmp\spark-9366ec94-dac7-4a5c-a74b-3e7594a692ab\test\InputOutputMetricsSuite.txt, expected: file:///
at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:642)
at org.apache.hadoop.fs.FileSystem.makeQualified(FileSystem.java:462)
at org.apache.hadoop.fs.FilterFileSystem.makeQualified(FilterFileSystem.java:114)
- input metrics when reading text file *** FAILED *** (110 milliseconds)
java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored
at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277)
at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202)
at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252)
- input metrics on records read - simple *** FAILED *** (125 milliseconds)
java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored
at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277)
at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202)
at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252)
- input metrics on records read - more stages *** FAILED *** (110 milliseconds)
java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored
at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277)
at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202)
at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252)
- input metrics on records - New Hadoop API *** FAILED *** (16 milliseconds)
java.lang.IllegalArgumentException: Wrong FS: file://C:\projects\spark\target\tmp\spark-3f10a1a4-7820-4772-b821-25fd7523bf6f\test\InputOutputMetricsSuite.txt, expected: file:///
at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:642)
at org.apache.hadoop.fs.FileSystem.makeQualified(FileSystem.java:462)
at org.apache.hadoop.fs.FilterFileSystem.makeQualified(FilterFileSystem.java:114)
- input metrics on records read with cache *** FAILED *** (93 milliseconds)
java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored
at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277)
at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202)
at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252)
- input read/write and shuffle read/write metrics all line up *** FAILED *** (93 milliseconds)
java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored
at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277)
at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202)
at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252)
- input metrics with interleaved reads *** FAILED *** (0 milliseconds)
java.lang.IllegalArgumentException: Wrong FS: file://C:\projects\spark\target\tmp\spark-2638d893-e89b-47ce-acd0-bbaeee78dd9b\InputOutputMetricsSuite_cart.txt, expected: file:///
at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:642)
at org.apache.hadoop.fs.FileSystem.makeQualified(FileSystem.java:462)
at org.apache.hadoop.fs.FilterFileSystem.makeQualified(FilterFileSystem.java:114)
- input metrics with old CombineFileInputFormat *** FAILED *** (157 milliseconds)
17947 was not greater than or equal to 300000 (InputOutputMetricsSuite.scala:324)
org.scalatest.exceptions.TestFailedException:
at org.scalatest.Assertions$class.newAssertionFailedException(Assertions.scala:500)
at org.scalatest.FunSuite.newAssertionFailedException(FunSuite.scala:1555)
at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:466)
- input metrics with new CombineFileInputFormat *** FAILED *** (16 milliseconds)
java.lang.IllegalArgumentException: Wrong FS: file://C:\projects\spark\target\tmp\spark-11920c08-19d8-4c7c-9fba-28ed72b79f80\test\InputOutputMetricsSuite.txt, expected: file:///
at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:642)
at org.apache.hadoop.fs.FileSystem.makeQualified(FileSystem.java:462)
at org.apache.hadoop.fs.FilterFileSystem.makeQualified(FilterFileSystem.java:114)

ReplayListenerSuite:

- End-to-end replay *** FAILED *** (121 milliseconds)
java.io.IOException: No FileSystem for scheme: C
at org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2421)
at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2428)
- End-to-end replay with compression *** FAILED *** (516 milliseconds)
java.io.IOException: No FileSystem for scheme: C
at org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2421)
at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2428)
at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:88)

EventLoggingListenerSuite:

- End-to-end event logging *** FAILED *** (7 seconds, 435 milliseconds)
java.io.IOException: No FileSystem for scheme: C
at org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2421)
at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2428)
at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:88)
- End-to-end event logging with compression *** FAILED *** (1 second)
java.io.IOException: No FileSystem for scheme: C
at org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2421)
at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2428)
at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:88)
- Event log name *** FAILED *** (16 milliseconds)
"file:/[]base-dir/app1" did not equal "file:/[C:/]base-dir/app1" (EventLoggingListenerSuite.scala:123)
org.scalatest.exceptions.TestFailedException:
at org.scalatest.Assertions$class.newAssertionFailedException(Assertions.scala:500)
at org.scalatest.FunSuite.newAssertionFailedException(FunSuite.scala:1555)
at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:466)

This PR proposes to fix the test failures on Windows

How was this patch tested?

Manually tested via AppVeyor

Before

RPackageUtilsSuite: https://ci.appveyor.com/project/spark-test/spark/build/273-RPackageUtilsSuite-before
InputOutputMetricsSuite: https://ci.appveyor.com/project/spark-test/spark/build/272-InputOutputMetricsSuite-before
ReplayListenerSuite: https://ci.appveyor.com/project/spark-test/spark/build/274-ReplayListenerSuite-before
EventLoggingListenerSuite: https://ci.appveyor.com/project/spark-test/spark/build/275-EventLoggingListenerSuite-before

After

RPackageUtilsSuite: https://ci.appveyor.com/project/spark-test/spark/build/270-RPackageUtilsSuite
InputOutputMetricsSuite: https://ci.appveyor.com/project/spark-test/spark/build/271-InputOutputMetricsSuite
ReplayListenerSuite: https://ci.appveyor.com/project/spark-test/spark/build/277-ReplayListenerSuite-after
EventLoggingListenerSuite: https://ci.appveyor.com/project/spark-test/spark/build/278-EventLoggingListenerSuite-after

…fied ones on Windows

HyukjinKwon · 2016-12-16T07:04:12Z

- if (!rPackageBuilder(rSource, printStream, verbose, RUtils.rPackages.get)) {
- print(s"ERROR: Failed to build R package in $file.", printStream)
- print(RJarDoc, printStream)
+ Utils.tryWithSafeFinally {


Actual change is as below:
Utils.tryWithSafeFinally { ... } { jar.close() }

HyukjinKwon · 2016-12-16T07:05:38Z

+ // Get the relative paths for proper naming in the zip file. Note that
+ // the separator should always be / for according to ZIP specification.
+ // `relPath` here should be, for example, "/packageTest/def.R" or "/test.R".
+ val relPath = file.toURI.toString.replaceFirst(dir.toURI.toString.stripSuffix("/"), "")


It should always be / according to ZIP specification (See 4.4.17 file name: (Variable) in https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT)

cc @shivaram, could I please ask to take a look for this one? This fixes the test, SparkR zipping works properly on Windows in RPackageUtilsSuite.

Yeah I think using / always is good. Could you write a small comment on what the toURI is accomplishing here (as opposed to the the getAbsolutePath we were using before)

Oh, I thought you meant writing a comment in the codes.. :).
it just replaces the \ on Windows to /. The reason for stripSuffix is, it seems it has a trailing / when the uri is known as a directory.

You can put it in the code as well :) Something like We convert dir to URI to force / and then remove trailing / that show up for directories

For example,
Before
Windows
vala= file.getAbsolutePath // "C:\...\tmp\1481863447985-0"valb= dir.getAbsolutePath // "C:\...\tmp\1481863447985-0\test.R" a.replaceFirst(b, "") // java.util.regex.PatternSyntaxException: Unknown character property name {r} near index 4
Full exception message:
[info] java.util.regex.PatternSyntaxException: Unknown character property name {r} near index 4 [info] C:\projects\spark\target\tmp\1481863447985-0 [info] ^ [info] at java.util.regex.Pattern.error(Pattern.java:1955) [info] at java.util.regex.Pattern.charPropertyNodeFor(Pattern.java:2781) [info] at java.util.regex.Pattern.family(Pattern.java:2736) [info] at java.util.regex.Pattern.sequence(Pattern.java:2076) [info] at java.util.regex.Pattern.expr(Pattern.java:1996) [info] at java.util.regex.Pattern.compile(Pattern.java:1696) [info] at java.util.regex.Pattern.<init>(Pattern.java:1351) [info] at java.util.regex.Pattern.compile(Pattern.java:1028) [info] at java.lang.String.replaceFirst(String.java:2178) [info] at org.apache.spark.deploy.RPackageUtils$$anonfun$zipRLibraries$2.apply(RPackageUtils.scala:235)
Linux/Mac
vala= file.getAbsolutePath // "/var/.../T/1481938681657-0/test.R"valb= dir.getAbsolutePath // "/var/.../T/1481938681657-0" a.replaceFirst(b, "") // "/test.R"
After
Windows
vala= file.toURI.toString // "file:/C:/.../tmp/1481863447985-0/test.R"valb= dir.toURI.toString // "file:/C:/.../tmp/1481863447985-0/" a.replaceFirst(b.stripSuffix("/"), "") // "/test.R"
Linux/Mac
vala= file.toURI.toString // "file:/var/.../T/1481938681657-0/test.R"valb= dir.toURI.toString // "file:/var/.../T/1481938681657-0/" a.replaceFirst(b.stripSuffix("/"), "") // "/test.R"

Sure, thanks!

SparkQA · 2016-12-16T07:07:42Z

Test build #70238 has started for PR 16305 at commit 00d5322.

HyukjinKwon · 2016-12-16T07:09:00Z

- assert(s"file:/base-dir/app1" === EventLoggingListener.getLogPath(
-Utils.resolveURI("/base-dir"), "app1", None))
+ assert(s"${baseDirUri.toString}/app1" === EventLoggingListener.getLogPath(
+baseDirUri, "app1", None))


On Windows, it compares
"file:/C:/base-dir/app1" === "file:/C:/base-dir/app1"
whereas on Linux and Mac,
"file:/base-dir/app1" === "file:/base-dir/app1"

HyukjinKwon · 2016-12-16T07:15:15Z

Build started: [TESTS] org.apache.spark.scheduler.EventLoggingListenerSuite
Build started: [TESTS] org.apache.spark.scheduler.ReplayListenerSuite
Build started: [TESTS] org.apache.spark.metrics.InputOutputMetricsSuite
Build started: [TESTS] org.apache.spark.deploy.RPackageUtilsSuite

Diff: master...spark-test:08CE93A8-BCB1-47D9-8683-755109827A62

HyukjinKwon · 2016-12-16T07:18:26Z

cc @srowen, Could you please take a look?

shivaram · 2016-12-16T08:16:01Z

Thanks @HyukjinKwon I'll take a look at this tomorrow - BTW do either you or @srowen know why we see errors of the form KeyError: -9 in Jenkins ? I also saw this on another PR [2]

...
File "./dev/run-tests-jenkins.py", line 219, in main
test_result_code, test_result_note = run_tests(tests_timeout)
File "./dev/run-tests-jenkins.py", line 140, in run_tests
test_result_note = ' * This patch **fails %s**.' % failure_note_by_errcode[test_result_code]
KeyError: -9

[2] https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70236/console for #16290

HyukjinKwon · 2016-12-16T09:11:12Z

#16307 seems too. I am not too sure but I think (IIRC) I have seen this time to time. I also want to know if these have been manually fixed by someone so far or simply it is something gone wrong in Jenkins itself. Apparently, it seems due to a problem within Jenkins though as it says this link, https://wiki.jenkins-ci.org/display/JENKINS/Spawning+processes+from+build

HyukjinKwon · 2016-12-16T10:58:19Z

retest this please

SparkQA · 2016-12-16T13:04:52Z

Test build #70247 has finished for PR 16305 at commit 00d5322.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2016-12-16T13:20:43Z

retest this please

SparkQA · 2016-12-16T15:23:33Z

Test build #70252 has finished for PR 16305 at commit 00d5322.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2016-12-16T17:51:48Z

Test build #3506 has started for PR 16305 at commit 00d5322.

shivaram · 2016-12-16T18:04:35Z

cc @shaneknapp #16305 (comment) is the comment with the Jenkins errors I was talking about

shaneknapp · 2016-12-16T18:39:30Z

re @shivaram -- this is totally bizarre, and nothing is popping in to mind about what could be causing this. it's definitely not the build timeout (5 hours) or the timeout in run-tests-jenkins.py, nor are any system cleanup cron jobs running that could be responsible for this.

i'll keep poking around and trying to figure this out.

shivaram · 2016-12-16T20:13:21Z

Had a minor question on the inline comment. Otherwise the RPackageUtils change LGTM

shaneknapp · 2016-12-16T20:55:02Z

test this please

SparkQA · 2016-12-16T21:44:55Z

Test build #70276 has finished for PR 16305 at commit 00d5322.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2016-12-17T01:00:47Z

retest this please

HyukjinKwon · 2016-12-17T01:02:37Z

Ah, thank you @shivaram and @shaneknapp.

SparkQA · 2016-12-17T03:32:19Z

Test build #70286 has finished for PR 16305 at commit 00d5322.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2016-12-17T04:50:56Z

Test build #70291 has finished for PR 16305 at commit 0475ac5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

shivaram · 2016-12-17T05:30:53Z

Thanks @HyukjinKwon - Merging into master

…st failures in identified ones on Windows ## What changes were proposed in this pull request? There are several tests failing due to resource-closing-related and path-related problems on Windows as below. - `RPackageUtilsSuite`: ``` - build an R package from a jar end to end *** FAILED *** (1 second, 625 milliseconds) java.io.IOException: Unable to delete file: C:\projects\spark\target\tmp\1481729427517-0\a\dep2\d\dep2-d.jar at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2279) at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653) at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1535) - faulty R package shows documentation *** FAILED *** (359 milliseconds) java.io.IOException: Unable to delete file: C:\projects\spark\target\tmp\1481729428970-0\dep1-c.jar at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2279) at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653) at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1535) - SparkR zipping works properly *** FAILED *** (47 milliseconds) java.util.regex.PatternSyntaxException: Unknown character property name {r} near index 4 C:\projects\spark\target\tmp\1481729429282-0 ^ at java.util.regex.Pattern.error(Pattern.java:1955) at java.util.regex.Pattern.charPropertyNodeFor(Pattern.java:2781) ``` - `InputOutputMetricsSuite`: ``` - input metrics for old hadoop with coalesce *** FAILED *** (240 milliseconds) java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277) at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202) at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252) - input metrics with cache and coalesce *** FAILED *** (109 milliseconds) java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277) at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202) at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252) - input metrics for new Hadoop API with coalesce *** FAILED *** (0 milliseconds) java.lang.IllegalArgumentException: Wrong FS: file://C:\projects\spark\target\tmp\spark-9366ec94-dac7-4a5c-a74b-3e7594a692ab\test\InputOutputMetricsSuite.txt, expected: file:/// at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:642) at org.apache.hadoop.fs.FileSystem.makeQualified(FileSystem.java:462) at org.apache.hadoop.fs.FilterFileSystem.makeQualified(FilterFileSystem.java:114) - input metrics when reading text file *** FAILED *** (110 milliseconds) java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277) at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202) at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252) - input metrics on records read - simple *** FAILED *** (125 milliseconds) java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277) at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202) at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252) - input metrics on records read - more stages *** FAILED *** (110 milliseconds) java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277) at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202) at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252) - input metrics on records - New Hadoop API *** FAILED *** (16 milliseconds) java.lang.IllegalArgumentException: Wrong FS: file://C:\projects\spark\target\tmp\spark-3f10a1a4-7820-4772-b821-25fd7523bf6f\test\InputOutputMetricsSuite.txt, expected: file:/// at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:642) at org.apache.hadoop.fs.FileSystem.makeQualified(FileSystem.java:462) at org.apache.hadoop.fs.FilterFileSystem.makeQualified(FilterFileSystem.java:114) - input metrics on records read with cache *** FAILED *** (93 milliseconds) java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277) at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202) at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252) - input read/write and shuffle read/write metrics all line up *** FAILED *** (93 milliseconds) java.io.IOException: Not a file: file:/C:/projects/spark/core/ignored at org.apache.hadoop.mapred.FileInputFormat.getSplits(FileInputFormat.java:277) at org.apache.spark.rdd.HadoopRDD.getPartitions(HadoopRDD.scala:202) at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252) - input metrics with interleaved reads *** FAILED *** (0 milliseconds) java.lang.IllegalArgumentException: Wrong FS: file://C:\projects\spark\target\tmp\spark-2638d893-e89b-47ce-acd0-bbaeee78dd9b\InputOutputMetricsSuite_cart.txt, expected: file:/// at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:642) at org.apache.hadoop.fs.FileSystem.makeQualified(FileSystem.java:462) at org.apache.hadoop.fs.FilterFileSystem.makeQualified(FilterFileSystem.java:114) - input metrics with old CombineFileInputFormat *** FAILED *** (157 milliseconds) 17947 was not greater than or equal to 300000 (InputOutputMetricsSuite.scala:324) org.scalatest.exceptions.TestFailedException: at org.scalatest.Assertions$class.newAssertionFailedException(Assertions.scala:500) at org.scalatest.FunSuite.newAssertionFailedException(FunSuite.scala:1555) at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:466) - input metrics with new CombineFileInputFormat *** FAILED *** (16 milliseconds) java.lang.IllegalArgumentException: Wrong FS: file://C:\projects\spark\target\tmp\spark-11920c08-19d8-4c7c-9fba-28ed72b79f80\test\InputOutputMetricsSuite.txt, expected: file:/// at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:642) at org.apache.hadoop.fs.FileSystem.makeQualified(FileSystem.java:462) at org.apache.hadoop.fs.FilterFileSystem.makeQualified(FilterFileSystem.java:114) ``` - `ReplayListenerSuite`: ``` - End-to-end replay *** FAILED *** (121 milliseconds) java.io.IOException: No FileSystem for scheme: C at org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2421) at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2428) - End-to-end replay with compression *** FAILED *** (516 milliseconds) java.io.IOException: No FileSystem for scheme: C at org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2421) at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2428) at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:88) ``` - `EventLoggingListenerSuite`: ``` - End-to-end event logging *** FAILED *** (7 seconds, 435 milliseconds) java.io.IOException: No FileSystem for scheme: C at org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2421) at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2428) at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:88) - End-to-end event logging with compression *** FAILED *** (1 second) java.io.IOException: No FileSystem for scheme: C at org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2421) at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2428) at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:88) - Event log name *** FAILED *** (16 milliseconds) "file:/[]base-dir/app1" did not equal "file:/[C:/]base-dir/app1" (EventLoggingListenerSuite.scala:123) org.scalatest.exceptions.TestFailedException: at org.scalatest.Assertions$class.newAssertionFailedException(Assertions.scala:500) at org.scalatest.FunSuite.newAssertionFailedException(FunSuite.scala:1555) at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:466) ``` This PR proposes to fix the test failures on Windows ## How was this patch tested? Manually tested via AppVeyor **Before** `RPackageUtilsSuite`: https://ci.appveyor.com/project/spark-test/spark/build/273-RPackageUtilsSuite-before `InputOutputMetricsSuite`: https://ci.appveyor.com/project/spark-test/spark/build/272-InputOutputMetricsSuite-before `ReplayListenerSuite`: https://ci.appveyor.com/project/spark-test/spark/build/274-ReplayListenerSuite-before `EventLoggingListenerSuite`: https://ci.appveyor.com/project/spark-test/spark/build/275-EventLoggingListenerSuite-before **After** `RPackageUtilsSuite`: https://ci.appveyor.com/project/spark-test/spark/build/270-RPackageUtilsSuite `InputOutputMetricsSuite`: https://ci.appveyor.com/project/spark-test/spark/build/271-InputOutputMetricsSuite `ReplayListenerSuite`: https://ci.appveyor.com/project/spark-test/spark/build/277-ReplayListenerSuite-after `EventLoggingListenerSuite`: https://ci.appveyor.com/project/spark-test/spark/build/278-EventLoggingListenerSuite-after Author: hyukjinkwon <gurwls223@gmail.com> Closesapache#16305 from HyukjinKwon/RPackageUtilsSuite-InputOutputMetricsSuite.

HyukjinKwon · 2017-03-17T07:40:03Z

@shaneknapp, about #16305 (comment), I know it is a too wide guess but I have seen this -9 when someone rebases multiple times before the build is started quickly and it seems making other builds failed too. I have seen this three-ish times recently. This is a wild guess but I would like to note this just in case that it might be a clue.

shaneknapp · 2017-03-17T17:29:09Z

yeah... there's really not much we can do about this. thanks for bringing it to my attention tho.

…

On Fri, Mar 17, 2017 at 12:40 AM, Hyukjin Kwon ***@***.***> wrote: @shaneknapp <https://github.com/shaneknapp>, about #16305 (comment) <#16305 (comment)>, I know it is a too wide guess but I have seen this -9 when someone rebases multiple times before the build is started quickly and it seems making other build failed too. I have seen this three-ish times recently. This is a wild guess but I would like to note this just in case. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16305 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABiDrN1jp8nEiu0mrg_oIYZBKa9iOcP7ks5rmjjwgaJpZM4LO5_z> .

HyukjinKwon added 2 commits December 16, 2016 14:27

Fix resource-closing-related and path-related test failures in identi…
22cb8fc
…fied ones on Windows

Fix EventLoggingListenerSuite too
00d5322

HyukjinKwon commented Dec 16, 2016
View reviewed changes

srowen approved these changes Dec 16, 2016
View reviewed changes

Update comment for sure
0475ac5

asfgit closed this in 2bc1c95Dec 17, 2016

HyukjinKwon mentioned this pull request Mar 17, 2017
[SPARK-19949][SQL] unify bad record handling in CSV and JSON #17315
Closed

HyukjinKwon deleted the RPackageUtilsSuite-InputOutputMetricsSuite branch January 2, 2018 03:43

Uh oh!

Conversation

HyukjinKwon commented Dec 16, 2016

What changes were proposed in this pull request?

How was this patch tested?

Uh oh!

HyukjinKwonDec 16, 2016

Choose a reason for hiding this comment

Uh oh!

HyukjinKwonDec 16, 2016

Choose a reason for hiding this comment

Uh oh!

HyukjinKwonDec 16, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shivaramDec 16, 2016

Choose a reason for hiding this comment

Uh oh!

HyukjinKwonDec 17, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shivaramDec 17, 2016

Choose a reason for hiding this comment

Uh oh!

HyukjinKwonDec 17, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HyukjinKwonDec 17, 2016

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Dec 16, 2016

Uh oh!

HyukjinKwonDec 16, 2016

Choose a reason for hiding this comment

Uh oh!

HyukjinKwon commented Dec 16, 2016

Uh oh!

HyukjinKwon commented Dec 16, 2016

Uh oh!

shivaram commented Dec 16, 2016

Uh oh!

HyukjinKwon commented Dec 16, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HyukjinKwon commented Dec 16, 2016

Uh oh!

SparkQA commented Dec 16, 2016

Uh oh!

HyukjinKwon commented Dec 16, 2016

Uh oh!

SparkQA commented Dec 16, 2016

Uh oh!

SparkQA commented Dec 16, 2016

Uh oh!

shivaram commented Dec 16, 2016

Uh oh!

shaneknapp commented Dec 16, 2016

Uh oh!

shivaram commented Dec 16, 2016

Uh oh!

shaneknapp commented Dec 16, 2016

Uh oh!

SparkQA commented Dec 16, 2016

Uh oh!

HyukjinKwon commented Dec 17, 2016

Uh oh!

HyukjinKwon commented Dec 17, 2016

Uh oh!

SparkQA commented Dec 17, 2016

Uh oh!

SparkQA commented Dec 17, 2016

Uh oh!

shivaram commented Dec 17, 2016

Uh oh!

HyukjinKwon commented Mar 17, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HyukjinKwonDec 16, 2016•
edited
Loading

HyukjinKwonDec 17, 2016•
edited
Loading

HyukjinKwonDec 17, 2016•
edited
Loading

HyukjinKwon commented Dec 16, 2016•
edited
Loading

HyukjinKwon commented Mar 17, 2017•
edited
Loading