Skip to content

[SPARK-18993][BUILD] Unable to build/compile Spark in IntelliJ due to missing Scala deps in spark-tags - #16418

Closed
srowen wants to merge 1 commit into
apache:masterfrom
srowen:SPARK-18993
Closed

[SPARK-18993][BUILD] Unable to build/compile Spark in IntelliJ due to missing Scala deps in spark-tags#16418
srowen wants to merge 1 commit into
apache:masterfrom
srowen:SPARK-18993

Conversation

@srowen

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This adds back a direct dependency on Scala library classes from spark-tags because its Scala annotations need them.

How was this patch tested?

Existing tests

@srowen

Copy link
Copy Markdown
MemberAuthor

CC @ryan-williams / @vanzin

@ryan-williams

Copy link
Copy Markdown
Contributor

good catch, thx

@SparkQA

Copy link
Copy Markdown

Test build #70645 has finished for PR 16418 at commit 4a07c63.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile

gatorsmile commented Dec 28, 2016

Copy link
Copy Markdown
Member

It works well. LGTM

asfgit pushed a commit that referenced this pull request Dec 28, 2016
… missing Scala deps in spark-tags
## What changes were proposed in this pull request?
This adds back a direct dependency on Scala library classes from spark-tags because its Scala annotations need them.
## How was this patch tested?
Existing tests
Author: Sean Owen <sowen@cloudera.com>
Closes#16418 from srowen/SPARK-18993.
(cherry picked from commit d7bce3b)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@srowen

Copy link
Copy Markdown
MemberAuthor

Merged to master/2.1/2.0 to match the preceding change. I figured it's sort of important to get IDEs back online.

asfgit pushed a commit that referenced this pull request Dec 28, 2016
… missing Scala deps in spark-tags
## What changes were proposed in this pull request?
This adds back a direct dependency on Scala library classes from spark-tags because its Scala annotations need them.
## How was this patch tested?
Existing tests
Author: Sean Owen <sowen@cloudera.com>
Closes#16418 from srowen/SPARK-18993.
(cherry picked from commit d7bce3b)
Signed-off-by: Sean Owen <sowen@cloudera.com>
cmonkey pushed a commit to cmonkey/spark that referenced this pull request Dec 29, 2016
… missing Scala deps in spark-tags
## What changes were proposed in this pull request?
This adds back a direct dependency on Scala library classes from spark-tags because its Scala annotations need them.
## How was this patch tested?
Existing tests
Author: Sean Owen <sowen@cloudera.com>
Closesapache#16418 from srowen/SPARK-18993.
@srowen
srowen deleted the SPARK-18993 branch December 30, 2016 10:32
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
… missing Scala deps in spark-tags
## What changes were proposed in this pull request?
This adds back a direct dependency on Scala library classes from spark-tags because its Scala annotations need them.
## How was this patch tested?
Existing tests
Author: Sean Owen <sowen@cloudera.com>
Closesapache#16418 from srowen/SPARK-18993.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@srowen@ryan-williams@SparkQA@gatorsmile