Skip to content

[WIP][SPARK-19257][SQL]CatalogStorageFormat.locationUri should be java.net.URI - #16619

Closed
windpiger wants to merge 11 commits into
apache:masterfrom
windpiger:URIstringToURI
Closed

[WIP][SPARK-19257][SQL]CatalogStorageFormat.locationUri should be java.net.URI#16619
windpiger wants to merge 11 commits into
apache:masterfrom
windpiger:URIstringToURI

Conversation

@windpiger

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Currently we treat CatalogStorageFormat.locationUri as URI string and always convert it to path by new Path(new URI(locationUri))
It will be safer if we can make the type of CatalogStorageFormat.locationUri java.net.URI. We should finish the TODO in https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala#L50-L52

How was this patch tested?

@SparkQA

Copy link
Copy Markdown

Test build #71514 has finished for PR 16619 at commit 2ab4928.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

Copy link
Copy Markdown

Test build #71515 has finished for PR 16619 at commit 758c8b5.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

Copy link
Copy Markdown

Test build #71516 has finished for PR 16619 at commit 5b5debf.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

Copy link
Copy Markdown

Test build #71518 has finished for PR 16619 at commit 635a398.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@windpigerwindpiger changed the title [SPARK-19257][SQL]CatalogStorageFormat.locationUri should be java.net.URI[WIP][SPARK-19257][SQL]CatalogStorageFormat.locationUri should be java.net.URIJan 18, 2017
@SparkQA

Copy link
Copy Markdown

Test build #71700 has finished for PR 16619 at commit 66dc4de.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

Copy link
Copy Markdown

Test build #71766 has finished for PR 16619 at commit 59736fa.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen

Copy link
Copy Markdown
Member

Should this be closed in favor of #17149 ?

@windpiger

Copy link
Copy Markdown
ContributorAuthor

yes I will close it , thanks! @srowen

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@windpiger@SparkQA@srowen