Uh oh!
There was an error while loading. Please reload this page.
[SPARK-19390][SQL] Replace the unnecessary usages of hiveQlTable - #16726
Closed
gatorsmile wants to merge 1 commit into
Closed
[SPARK-19390][SQL] Replace the unnecessary usages of hiveQlTable#16726gatorsmile wants to merge 1 commit into
gatorsmile wants to merge 1 commit into
Conversation
SparkQA
commented
Jan 28, 2017
Test build #72102 has started for PR 16726 at commit |
gatorsmile
commented
Jan 28, 2017
MemberAuthor
retest this please |
SparkQA
commented
Jan 28, 2017
Test build #72108 has finished for PR 16726 at commit
|
dongjoon-hyun
commented
Jan 31, 2017
Member
+1 for reducing the dependency! |
gatorsmile
commented
Feb 3, 2017
MemberAuthor
cc @cloud-fan |
Contributor
There was a problem hiding this comment.
can we remove hiveQlTable now?
MemberAuthor
There was a problem hiding this comment.
The whole test case for #14515 is not needed after the recent code refactoring.
gatorsmileforce-pushed
the
cleanupMetastoreRelation
branch
from
February 20, 2017 07:20
e9e7486 to
75d8017Comparegatorsmile
commented
Feb 20, 2017
| case InsertIntoTable(r: MetastoreRelation, partition, query, overwrite, ifNotExists) | ||
| // Inserting into partitioned table is not supported in Parquet data source (yet). | ||
| if query.resolved && !r.hiveQlTable.isPartitioned && shouldConvertMetastoreParquet(r) => | ||
| if query.resolved && !r.catalogTable.isPartitioned && shouldConvertToParquet(r) => |
MemberAuthor
There was a problem hiding this comment.
Exceed 101 characters. Thus,,, rename it.
SparkQA
commented
Feb 20, 2017
Test build #73153 has started for PR 16726 at commit |
gatorsmile
commented
Feb 20, 2017
MemberAuthor
retest this please |
SparkQA
commented
Feb 20, 2017
Test build #73179 has finished for PR 16726 at commit
|
cloud-fan
commented
Feb 20, 2017
Contributor
can you hold it for a while? I'm removing the |
gatorsmile
commented
Feb 21, 2017
MemberAuthor
Great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
catalogTableis the native table metadata structure for Spark SQL. Thus, we should avoid using Hive's table metadata structureTablein our code base. This PR is to replace it.How was this patch tested?
The existing test cases.