Uh oh!
There was an error while loading. Please reload this page.
[SPARK-19406] [SQL] Fix function to_json to respect user-provided options - #16745
Closed
gatorsmile wants to merge 1 commit into
Closed
[SPARK-19406] [SQL] Fix function to_json to respect user-provided options#16745gatorsmile wants to merge 1 commit into
gatorsmile wants to merge 1 commit into
Conversation
gatorsmile
commented
Jan 30, 2017
MemberAuthor
marmbrus
commented
Jan 30, 2017
Contributor
LGTM |
HyukjinKwon
commented
Jan 30, 2017
Member
LGTM too. |
SparkQA
commented
Jan 31, 2017
Test build #72174 has finished for PR 16745 at commit
|
asfgit pushed a commit
that referenced
this pull request
Jan 31, 2017
### What changes were proposed in this pull request?
Currently, the function `to_json` allows users to provide options for generating JSON. However, it does not pass it to `JacksonGenerator`. Thus, it ignores the user-provided options. This PR is to fix it. Below is an example.
```Scala
val df = Seq(Tuple1(Tuple1(java.sql.Timestamp.valueOf("2015-08-26 18:00:00.0")))).toDF("a")
val options = Map("timestampFormat" -> "dd/MM/yyyy HH:mm")
df.select(to_json($"a", options)).show(false)
```
The current output is like
```
+--------------------------------------+
|structtojson(a) |
+--------------------------------------+
|{"_1":"2015-08-26T18:00:00.000-07:00"}|
+--------------------------------------+
```
After the fix, the output is like
```
+-------------------------+
|structtojson(a) |
+-------------------------+
|{"_1":"26/08/2015 18:00"}|
+-------------------------+
```
### How was this patch tested?
Added test cases for both `from_json` and `to_json`
Author: gatorsmile <gatorsmile@gmail.com>
Closes#16745 from gatorsmile/toJson.
(cherry picked from commit f9156d2)
Signed-off-by: gatorsmile <gatorsmile@gmail.com>gatorsmile
commented
Jan 31, 2017
MemberAuthor
Thanks! Merging to master/2.1 |
cmonkey pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 15, 2017
### What changes were proposed in this pull request?
Currently, the function `to_json` allows users to provide options for generating JSON. However, it does not pass it to `JacksonGenerator`. Thus, it ignores the user-provided options. This PR is to fix it. Below is an example.
```Scala
val df = Seq(Tuple1(Tuple1(java.sql.Timestamp.valueOf("2015-08-26 18:00:00.0")))).toDF("a")
val options = Map("timestampFormat" -> "dd/MM/yyyy HH:mm")
df.select(to_json($"a", options)).show(false)
```
The current output is like
```
+--------------------------------------+
|structtojson(a) |
+--------------------------------------+
|{"_1":"2015-08-26T18:00:00.000-07:00"}|
+--------------------------------------+
```
After the fix, the output is like
```
+-------------------------+
|structtojson(a) |
+-------------------------+
|{"_1":"26/08/2015 18:00"}|
+-------------------------+
```
### How was this patch tested?
Added test cases for both `from_json` and `to_json`
Author: gatorsmile <gatorsmile@gmail.com>
Closesapache#16745 from gatorsmile/toJson.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, the function
to_jsonallows users to provide options for generating JSON. However, it does not pass it toJacksonGenerator. Thus, it ignores the user-provided options. This PR is to fix it. Below is an example.The current output is like
After the fix, the output is like
How was this patch tested?
Added test cases for both
from_jsonandto_json