[SPARK-19386][SPARKR][DOC] Bisecting k-means in SparkR documentation by krishnakalyan3 · Pull Request #16767 · apache/spark

krishnakalyan3 · 2017-02-01T17:38:01Z

What changes were proposed in this pull request?

Update programming guide, example and vignette with Bisecting k-means.

AmplabJenkins · 2017-02-01T17:43:17Z

Can one of the admins verify this patch?

felixcheung · 2017-02-01T18:16:29Z


 * Latent Dirichlet Allocation (LDA)

+* Bisecting $k$-means


please sort this

@felixcheung could you please let me know whats wrong here?

these model names are in order
#### Clustering * Gaussian Mixture Model (GMM) * $k$-means Clustering * Latent Dirichlet Allocation (LDA) * Bisecting $k$-means
should be
#### Clustering * Bisecting $k$-means * Gaussian Mixture Model (GMM) * $k$-means Clustering * Latent Dirichlet Allocation (LDA)

felixcheung · 2017-02-01T18:17:19Z

 perplexity
 ```

+#### Bisecting k-means


ditto for this

same here. the model sections are in alphabetic order

felixcheung · 2017-02-01T18:17:29Z

@wangmiao1981

felixcheung · 2017-02-01T18:17:58Z

+
+<div data-lang="r" markdown="1">
+
+Refer to the [R API docs](api/R/spark.bisectingKmeans.html) for more details. {% include_example r/ml/bisectingKmeans.R %}


you will need to add this file r/ml/bisectingKmeans.R

and this {% include_example r/ml/bisectingKmeans.R %} should be a separate line

felixcheung · 2017-02-01T18:18:47Z

+
+Refer to the [R API docs](api/R/spark.bisectingKmeans.html) for more details. {% include_example r/ml/bisectingKmeans.R %}
+
+{% include_example r/ml/lda.R %}


this is incorrect

wangmiao1981 · 2017-02-01T19:04:28Z

wangmiao1981 · 2017-02-01T19:05:43Z

R function???s something wrong?

wangmiao1981 · 2017-02-01T19:06:16Z

I don't see the change here either. Is there something wrong with your editor? node???s

wangmiao1981 · 2017-02-01T19:25:19Z

+sparkR.session(appName = "SparkR-ML-bisectingKmeans-example")
+
+# $example on$
+irisDF <- suppressWarnings(createDataFrame(iris))


suppressWarnings should not appear in example.

wangmiao1981 · 2017-02-01T19:26:31Z

+fitted.model <- fitted(model, "centers")
+
+# Model summary
+showDF(fitted.model)


Model Summary should use summary method. Otherwise, change the comment.

krishnakalyan3 · 2017-02-01T19:26:54Z

@wangmiao1981 sorry, had made a erroneous commit. Could you please review the PR?.

krishnakalyan3 · 2017-02-02T12:30:31Z

ping @wangmiao1981 @felixcheung

felixcheung · 2017-02-02T17:36:28Z

looking good to me. I'll wait for @wangmiao1981 to review.

wangmiao1981 · 2017-02-02T19:30:41Z

LGTM

felixcheung · 2017-02-03T20:20:06Z

merged to master

wangmiao1981 · 2017-02-04T01:35:20Z

Jenkins build was not triggered for the last revision. It breaks the build.

felixcheung · 2017-02-04T08:09:14Z

ouch, Jenkins was never run the entire time. I need to go double check why AppVeyor is passing.

## What changes were proposed in this pull request? Update programming guide, example and vignette with Bisecting k-means. Author: krishnakalyan3 <krishnakalyan3@gmail.com> Closesapache#16767 from krishnakalyan3/bisecting-kmeans.

add bisectingKmeans
f907343

krishnakalyan3 changed the title ~~[SPARK-19386][SPARKR][DOC]~~[SPARK-19386][SPARKR][DOC] Bisecting k-means in SparkR documentationFeb 1, 2017

felixcheung reviewed Feb 1, 2017
View reviewed changes

wangmiao1981 reviewed Feb 1, 2017
View reviewed changes

Comment threadR/pkg/vignettes/sparkr-vignettes.Rmd Outdated
wangmiao1981Feb 1, 2017
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ???

wangmiao1981 reviewed Feb 1, 2017
View reviewed changes

Comment threadR/pkg/vignettes/sparkr-vignettes.Rmd Outdated
wangmiao1981Feb 1, 2017•
edited
Loading
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
R function???s something wrong?

wangmiao1981 reviewed Feb 1, 2017
View reviewed changes

krishnakalyan3 force-pushed the bisecting-kmeans branch from 5ba47b1 to f907343Compare February 1, 2017 19:18

krishnakalyan3 added 2 commits February 1, 2017 20:20

fix lda bad commit
66fd027

example
73e1c12

wangmiao1981 reviewed Feb 1, 2017
View reviewed changes

krishnakalyan3 added 2 commits February 1, 2017 20:29

fix supress and summary
240c989

fix orider
0cfb891

asfgit closed this in 48aafedFeb 3, 2017

actuaryzhang mentioned this pull request Feb 4, 2017
[SPARK-19452][SparkR] Fix bug in the name assignment method #16794
Closed

wangmiao1981 mentioned this pull request Feb 4, 2017
[SPARK-10063] Follow-up: remove dead code related to an old output committer. #16796
Closed

krishnakalyan3 deleted the bisecting-kmeans branch February 5, 2017 08:46


		<div data-lang="r" markdown="1">

		Refer to the [R API docs](api/R/spark.bisectingKmeans.html) for more details. {% include_example r/ml/bisectingKmeans.R %}


		Refer to the [R API docs](api/R/spark.bisectingKmeans.html) for more details. {% include_example r/ml/bisectingKmeans.R %}

		{% include_example r/ml/lda.R %}

Uh oh!

Conversation

krishnakalyan3 commented Feb 1, 2017

What changes were proposed in this pull request?

Uh oh!

AmplabJenkins commented Feb 1, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

felixcheung commented Feb 1, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wangmiao1981Feb 1, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wangmiao1981Feb 1, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

krishnakalyan3 commented Feb 1, 2017

Uh oh!

krishnakalyan3 commented Feb 2, 2017

Uh oh!

felixcheung commented Feb 2, 2017

Uh oh!

wangmiao1981 commented Feb 2, 2017

Uh oh!

felixcheung commented Feb 3, 2017

Uh oh!

wangmiao1981 commented Feb 4, 2017

Uh oh!

felixcheung commented Feb 4, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wangmiao1981Feb 1, 2017•
edited
Loading

wangmiao1981Feb 1, 2017•
edited
Loading