Skip to content

[SPARK-19386][SparkR][Followup] fix error in vignettes - #16799

Closed
actuaryzhang wants to merge 1 commit into
apache:masterfrom
actuaryzhang:sparkRVignettes
Closed

[SPARK-19386][SparkR][Followup] fix error in vignettes#16799
actuaryzhang wants to merge 1 commit into
apache:masterfrom
actuaryzhang:sparkRVignettes

Conversation

@actuaryzhang

@actuaryzhangactuaryzhang commented Feb 4, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Current version has error in vignettes:

model <- spark.bisectingKmeans(df, Sepal_Length ~ Sepal_Width, k = 4)
summary(kmeansModel)

kmeansModel does not exist...

@felixcheung@wangmiao1981

@actuaryzhangactuaryzhang mentioned this pull request Feb 4, 2017
Closed
@actuaryzhang

actuaryzhang commented Feb 4, 2017

Copy link
Copy Markdown
ContributorAuthor

Errors can be seen in #16794.

@actuaryzhangactuaryzhang changed the title [SparkR] fix error in vignettes[SPARK-19386][SparkR][Followup] fix error in vignettesFeb 4, 2017
@wangmiao1981

wangmiao1981 commented Feb 4, 2017

Copy link
Copy Markdown
Contributor

Good catch! Thanks for fixing it!

@felixcheung This is a hot-fix to build break. I don't know why Jenkins didn't catch it in the original PR.

@wangmiao1981wangmiao1981 mentioned this pull request Feb 4, 2017
Closed
@wangmiao1981

wangmiao1981 commented Feb 4, 2017

Copy link
Copy Markdown
Contributor

Jenkins, test this please.

@wangmiao1981

wangmiao1981 commented Feb 4, 2017

Copy link
Copy Markdown
Contributor

LGTM. Let us wait for Jenkins to build it.

@gatorsmilegatorsmile mentioned this pull request Feb 4, 2017
Closed
@SparkQA

SparkQA commented Feb 4, 2017

Copy link
Copy Markdown

Test build #72338 has finished for PR 16799 at commit 9552f1f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile

gatorsmile commented Feb 4, 2017

Copy link
Copy Markdown
Member

Since this PR is a HOT fix, let me merge it now. Thanks!

@gatorsmile

gatorsmile commented Feb 4, 2017

Copy link
Copy Markdown
Member

Thanks! Merging to master.

@asfgitasfgit closed this in 050c20cFeb 4, 2017
@SparkQA

SparkQA commented Feb 4, 2017

Copy link
Copy Markdown

Test build #72342 has finished for PR 16799 at commit 9552f1f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung

felixcheung commented Feb 4, 2017

Copy link
Copy Markdown
Member

thanks @gatorsmile, @actuaryzhang@wangmiao1981
we did see it on the other PR but I didn't put the two together. And sorry for missing the fact that Jenkins was never run on the PR that broken the build - comment threads were too long and AppVeyor green checkmark was there (need to follow up) - will be more careful the next time.

@actuaryzhang
actuaryzhang deleted the sparkRVignettes branch February 4, 2017 18:50
cmonkey pushed a commit to cmonkey/spark that referenced this pull request Feb 15, 2017
@actuaryzhang@cmonkey
[SPARK-19386][SPARKR][FOLLOWUP] fix error in vignettes
15a78de
## What changes were proposed in this pull request?
Current version has error in vignettes:
```
model <- spark.bisectingKmeans(df, Sepal_Length ~ Sepal_Width, k = 4)
summary(kmeansModel)
```
`kmeansModel` does not exist...
felixcheung wangmiao1981
Author: actuaryzhang <actuaryzhang10@gmail.com>
Closesapache#16799 from actuaryzhang/sparkRVignettes.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@actuaryzhang@wangmiao1981@SparkQA@gatorsmile@felixcheung