Uh oh!
There was an error while loading. Please reload this page.
[SPARK-19604] [TESTS] Log the start of every Python test - #16935
Closed
yhuai wants to merge 1 commit into
Closed
Conversation
… Python test file. We should also log the start of a test. So, if a test is hanging, we can tell which test file is running.
SparkQA
commented
Feb 15, 2017
Test build #72919 has finished for PR 16935 at commit
|
yhuai
commented
Feb 15, 2017
ContributorAuthor
Let's not merge it right now. I may need to log more. |
srowen
approved these changes
Feb 15, 2017
yhuai
commented
Feb 15, 2017
ContributorAuthor
ok. Nothing new to add. I will merge this to master and branch-2.1 (in case we want to debug any python test hanging issue in branch-2.1). |
liancheng
commented
Feb 15, 2017
Contributor
Merging to master an branch-2.1. |
yhuai
commented
Feb 15, 2017
ContributorAuthor
Seems I cannot merge now... Will try again later. |
liancheng
commented
Feb 15, 2017
Contributor
Me neither... |
asfgit pushed a commit
that referenced
this pull request
Feb 16, 2017
## What changes were proposed in this pull request? Right now, we only have info level log after we finish the tests of a Python test file. We should also log the start of a test. So, if a test is hanging, we can tell which test file is running. ## How was this patch tested? This is a change for python tests. Author: Yin Huai <yhuai@databricks.com> Closes#16935 from yhuai/SPARK-19604. (cherry picked from commit f6c3bba) Signed-off-by: Yin Huai <yhuai@databricks.com>
yhuai
commented
Feb 16, 2017
ContributorAuthor
cool. It has been merged. |
cmonkey pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 16, 2017
## What changes were proposed in this pull request? Right now, we only have info level log after we finish the tests of a Python test file. We should also log the start of a test. So, if a test is hanging, we can tell which test file is running. ## How was this patch tested? This is a change for python tests. Author: Yin Huai <yhuai@databricks.com> Closesapache#16935 from yhuai/SPARK-19604.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Right now, we only have info level log after we finish the tests of a Python test file. We should also log the start of a test. So, if a test is hanging, we can tell which test file is running.
How was this patch tested?
This is a change for python tests.