Uh oh!
There was an error while loading. Please reload this page.
[SPARK-19662][SCHEDULER][TEST] Add Fair Scheduler Unit Test coverage for different build cases - #16992
[SPARK-19662][SCHEDULER][TEST] Add Fair Scheduler Unit Test coverage for different build cases#16992erenavsarogullari wants to merge 3 commits into
Conversation
erenavsarogullari
commented
Feb 19, 2017
kayousterhout
commented
Feb 23, 2017
Jenkins this is ok to test |
kayousterhout
commented
Feb 23, 2017
@erenavsarogullari there are currently a bunch of higher priority outstanding scheduler PRs, so I'm guessing it will take a while for anyone to get a chance to review this, just so you know. |
SparkQA
commented
Feb 24, 2017
Test build #73367 has finished for PR 16992 at commit
|
jiangxb1987
commented
Jun 20, 2017
Could you please bring this up-to-date? @erenavsarogullari |
SparkQA
commented
Jul 22, 2017
Test build #79854 has finished for PR 16992 at commit
|
erenavsarogullari
commented
Jul 22, 2017
Hi @kayousterhout@markhamstra@squito, |
squito
left a comment
There was a problem hiding this comment.
@erenavsarogullari sorry this has taken forever to review! lgtm, just a super tiny nit on wording in the docs.
There was a problem hiding this comment.
super nit:
... and either putting a file named fairscheduler.xml on the classpath, or setting spark.scheduler.allocation.file ...
squito
commented
Aug 18, 2017
been a while so lets run tests again just to check: |
SparkQA
commented
Aug 21, 2017
Test build #3893 has finished for PR 16992 at commit
|
erenavsarogullari
commented
Aug 27, 2017
Hi @squito, Thanks for the review this patch. It is ready to re-review / merge. |
SparkQA
commented
Aug 27, 2017
Test build #81168 has finished for PR 16992 at commit
|
SparkQA
commented
Aug 27, 2017
Test build #81169 has finished for PR 16992 at commit
|
squito
commented
Aug 28, 2017
merged to master thanks @erenavsarogullari , sorry again for the delays |
What changes were proposed in this pull request?
Fair Scheduler can be built via one of the following options:
spark.scheduler.allocation.fileproperty,fairscheduler.xmlinto classpath.These options are checked in order and fair-scheduler is built via first found option. If invalid path is found,
FileNotFoundExceptionwill be expected.This PR aims unit test coverage of these use cases and a minor documentation change has been added for second option(
fairscheduler.xmlinto classpath) to inform the users.Also, this PR was related with #16813 and has been created separately to keep patch content as isolated and to help the reviewers.
How was this patch tested?
Added new Unit Tests.