Uh oh!
There was an error while loading. Please reload this page.
[SPARK-19459] Support for nested char/varchar fields in ORC - #17030
Closed
hvanhovell wants to merge 2 commits into
Closed
[SPARK-19459] Support for nested char/varchar fields in ORC#17030hvanhovell wants to merge 2 commits into
hvanhovell wants to merge 2 commits into
Conversation
hvanhovell
commented
Feb 22, 2017
ContributorAuthor
cc @cloud-fan |
SparkQA
commented
Feb 23, 2017
Test build #73301 has finished for PR 17030 at commit
|
| case _ => | ||
| } | ||
| val rawDataType = typedVisit[DataType](ctx.dataType) | ||
| builder.putString(HIVE_TYPE_STRING, rawDataType.catalogString) |
Contributor
There was a problem hiding this comment.
the tests failed because we always put the hive type string. We should only do it when there is char/varchar type
SparkQA
commented
Feb 23, 2017
Test build #73346 has finished for PR 17030 at commit
|
Contributor
thanks, merging to master! |
hvanhovell added a commit
to hvanhovell/spark
that referenced
this pull request
Feb 23, 2017
## What changes were proposed in this pull request? This PR is a small follow-up on apache#16804. This PR also adds support for nested char/varchar fields in orc. ## How was this patch tested? I have added a regression test to the OrcSourceSuite. Author: Herman van Hovell <hvanhovell@databricks.com> Closesapache#17030 from hvanhovell/SPARK-19459-follow-up. # Conflicts: # sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala # sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcSourceSuite.scala
hvanhovell added a commit
to hvanhovell/spark
that referenced
this pull request
Feb 23, 2017
## What changes were proposed in this pull request? This PR is a small follow-up on apache#16804. This PR also adds support for nested char/varchar fields in orc. ## How was this patch tested? I have added a regression test to the OrcSourceSuite. Author: Herman van Hovell <hvanhovell@databricks.com> Closesapache#17030 from hvanhovell/SPARK-19459-follow-up. # Conflicts: # sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala # sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcSourceSuite.scala
Yunni pushed a commit
to Yunni/spark
that referenced
this pull request
Feb 27, 2017
## What changes were proposed in this pull request? This PR is a small follow-up on apache#16804. This PR also adds support for nested char/varchar fields in orc. ## How was this patch tested? I have added a regression test to the OrcSourceSuite. Author: Herman van Hovell <hvanhovell@databricks.com> Closesapache#17030 from hvanhovell/SPARK-19459-follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a small follow-up on #16804. This PR also adds support for nested char/varchar fields in orc.
How was this patch tested?
I have added a regression test to the OrcSourceSuite.