Uh oh!
There was an error while loading. Please reload this page.
[SPARK-16844][SQL] Support codegen for sort-based aggreagate - #17164
[SPARK-16844][SQL] Support codegen for sort-based aggreagate#17164maropu wants to merge 3 commits into
Conversation
SparkQA
commented
Mar 4, 2017
Test build #73907 has finished for PR 17164 at commit
|
maropu
commented
Mar 4, 2017
A benchmark result: |
maropu
commented
Mar 4, 2017
|
maropu
commented
Mar 4, 2017
|
maropu
commented
Mar 4, 2017
@hvanhovell I reworked #14481 though, I'm not sure it is still worth trying this codegen. Could you give me insight first? Thanks! |
SparkQA
commented
Mar 4, 2017
Test build #73908 has finished for PR 17164 at commit
|
hvanhovell
commented
Mar 4, 2017
@maropu I think this is pretty exciting. This is very useful in situations where we have a lot of groups, in that case I will happily take a 2x performance improvement any day. This is still pretty decent if you consider that this aggregate is dominate by sorting. |
@hvanhovell okay! I'll brush up code, then if I finished, I'll let you know for code review. Thanks. |
a45048a to
b29c22dCompareSparkQA
commented
Mar 5, 2017
Test build #73924 has finished for PR 17164 at commit
|
SparkQA
commented
Mar 5, 2017
Test build #73925 has finished for PR 17164 at commit
|
SparkQA
commented
Mar 5, 2017
Test build #73926 has finished for PR 17164 at commit
|
SparkQA
commented
Mar 5, 2017
Test build #73935 has finished for PR 17164 at commit
|
8413dd7 to
29c713bCompareSparkQA
commented
Mar 6, 2017
Test build #73948 has finished for PR 17164 at commit
|
SparkQA
commented
Mar 6, 2017
Test build #73949 has finished for PR 17164 at commit
|
SparkQA
commented
Mar 6, 2017
Test build #73952 has finished for PR 17164 at commit
|
SparkQA
commented
Mar 6, 2017
Test build #73974 has started for PR 17164 at commit |
maropu
commented
Mar 6, 2017
Jenkins, retest this please. |
SparkQA
commented
Mar 6, 2017
Test build #73986 has finished for PR 17164 at commit
|
maropu
commented
Mar 6, 2017
Jenkins, retest this please. |
SparkQA
commented
Mar 6, 2017
Test build #73993 has finished for PR 17164 at commit
|
SparkQA
commented
Mar 7, 2017
Test build #74066 has finished for PR 17164 at commit
|
maropu
commented
Mar 7, 2017
This pr added an new SQL option |
maropu
commented
Mar 10, 2017
@hvanhovell ping |
There was a problem hiding this comment.
Do we need to use while? Can we use if instead of while?
There was a problem hiding this comment.
IIUC we can't because continue may exist in ${consume(ctx, resultVars).trim}.
There was a problem hiding this comment.
Do we need this do { } while (false);?
maropu
commented
Mar 14, 2017
@hvanhovell ping |
SparkQA
commented
Mar 15, 2017
Test build #74569 has finished for PR 17164 at commit
|
maropu
commented
Mar 18, 2017
@hvanhovell ping |
hvanhovell
commented
Mar 26, 2017
@maropu I do think this is useful. However we really need to refactor the planner, if we want to get the most value from this. |
maropu
commented
Mar 27, 2017
okay, it'd be better to close this? |
hvanhovell
commented
Mar 27, 2017
@maropu I am not sure. I like to keep interesting PRs open. Would you be interested in doing some work on the planner? |
maropu
commented
Mar 27, 2017
okay, I keep this open. Yea, sure and I'm interested in. If there are sub-tasks for that, I'd be grad if you ping me. Thanks! |
gatorsmile
commented
Jun 13, 2017
@maropu Maybe we can close this PR at first? |
maropu
commented
Jun 13, 2017
ok |
What changes were proposed in this pull request?
This pr supported codegen for
SortAggregate.This is the rework of #14481.
Close#14481
How was this patch tested?
Checked tests in
DataFrameAggregateSuite.