Uh oh!
There was an error while loading. Please reload this page.
[SPARK-19919][SQL] Defer throwing the exception for empty paths in CSV datasource into DataSource - #17256
Closed
HyukjinKwon wants to merge 3 commits into
Closed
[SPARK-19919][SQL] Defer throwing the exception for empty paths in CSV datasource into DataSource#17256HyukjinKwon wants to merge 3 commits into
DataSource#17256HyukjinKwon wants to merge 3 commits into
Conversation
SparkQA
commented
Mar 11, 2017
Test build #74381 has started for PR 17256 at commit |
HyukjinKwon
commented
Mar 11, 2017
MemberAuthor
retest this please |
SparkQA
commented
Mar 11, 2017
Test build #74386 has finished for PR 17256 at commit
|
DataSourceDataSourceHyukjinKwon
commented
Mar 12, 2017
| * Infers the schema from `inputPaths` files. | ||
| */ | ||
| def infer( | ||
| final def infer( |
MemberAuthor
There was a problem hiding this comment.
This resembles JsonDataSource's one.
SparkQA
commented
Mar 12, 2017
Test build #74401 has finished for PR 17256 at commit
|
DataSourceDataSourceSparkQA
commented
Mar 13, 2017
Test build #74425 has started for PR 17256 at commit |
HyukjinKwon
commented
Mar 13, 2017
MemberAuthor
retest this please |
SparkQA
commented
Mar 13, 2017
Test build #74432 has finished for PR 17256 at commit
|
HyukjinKwon
commented
Mar 22, 2017
MemberAuthor
cc @cloud-fan, could you see if it sounds good? |
cloud-fan
commented
Mar 22, 2017
Contributor
LGTM, merging to master! |
HyukjinKwon
commented
Mar 22, 2017
MemberAuthor
Thank you @cloud-fan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to defer throwing the exception within
DataSource.Currently, if other datasources fail to infer the schema, it returns
Noneand then this is being validated inDataSourceas below:However, CSV it checks it within the datasource implementation and throws another exception message as below:
We could remove this duplicated check and validate this in one place in the same way with the same message.
How was this patch tested?
Unit test in
CSVSuiteand manual test.