Uh oh!
There was an error while loading. Please reload this page.
[DOCS] Clarify round mode for format_number & round functions - #17399
[DOCS] Clarify round mode for format_number & round functions#17399roxannemoslehi wants to merge 2 commits into
Conversation
AmplabJenkins
commented
Mar 23, 2017
Can one of the admins verify this patch? |
srowen
commented
Mar 23, 2017
Have a look at http://spark.apache.org/contributing.html as the template says. |
roxannemoslehi
commented
Mar 23, 2017
Hmm @srowen do you mean describe HALF_EVEN round mode? Also, I know some of the other functions that use this type of rounding already include it in their definition. |
srowen
commented
Mar 23, 2017
No I really meant fill out the PR a little more (see link). The title isn't descriptive. |
ash211
commented
Mar 23, 2017
Thanks for contributing to Spark @roxannemoslehi ! I think Sean just means updating the title to something more like |
rxin
commented
Mar 23, 2017
Yea we definitely need a better title. Thanks for contributing though. |
rxin
commented
Mar 24, 2017
@roxannemoslehi can you fix the title? We can then merge this. |
roxannemoslehi
commented
Mar 24, 2017
Yup! Sorry about that everyone. Looks like my intended commit message didn't make it through originally but should be fixed now! |
srowen
commented
Mar 24, 2017
How about the doc of the |
roxannemoslehi
commented
Mar 24, 2017
Looks like round uses |
rxin
commented
Mar 24, 2017
Thanks - merging in master. |
## What changes were proposed in this pull request? This PR proposes to match minor documentations changes in #17399 and #17380 to R/Python. ## How was this patch tested? Manual tests in Python , Python tests via `./python/run-tests.py --module=pyspark-sql` and lint-checks for Python/R. Author: hyukjinkwon <gurwls223@gmail.com> Closes#17429 from HyukjinKwon/minor-match-doc.
What changes were proposed in this pull request?
Updated the description for the
format_numberdescription to indicate that it usesHALF_EVENrounding. Updated the description for therounddescription to indicate that it usesHALF_UProunding.How was this patch tested?
Just changing the two function comments so no testing involved.
Please review http://spark.apache.org/contributing.html before opening a pull request.