Skip to content

[SPARK-20300][ML][PYSPARK] Python API for ALSModel.recommendForAllUsers,Items - #17622

Closed
MLnick wants to merge 2 commits into
apache:masterfrom
MLnick:SPARK-20300-pyspark-recall
Closed

[SPARK-20300][ML][PYSPARK] Python API for ALSModel.recommendForAllUsers,Items#17622
MLnick wants to merge 2 commits into
apache:masterfrom
MLnick:SPARK-20300-pyspark-recall

Conversation

@MLnick

Copy link
Copy Markdown
Contributor

Add Python API for ALSModel methods recommendForAllUsers, recommendForAllItems

How was this patch tested?

New doc tests.

@MLnick

Copy link
Copy Markdown
ContributorAuthor

cc @jkbradley

@SparkQA

Copy link
Copy Markdown

Test build #75745 has finished for PR 17622 at commit abe6cfb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Comment threadpython/pyspark/ml/recommendation.py Outdated
"""
Returns top `numUsers` users recommended for each item, for all items.

:param numItems: max number of recommendations for each item

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

numItems -> numUsers

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@viirya

Copy link
Copy Markdown
Member

LGTM except for a doc comment.

@SparkQA

Copy link
Copy Markdown

Test build #76099 has finished for PR 17622 at commit 7644e51.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@MLnick

Copy link
Copy Markdown
ContributorAuthor

If no other comments (@jkbradley) I will merge to branch-2.2 in a few days.

@MLnick

Copy link
Copy Markdown
ContributorAuthor

Merged to master/branch-2.2

asfgit pushed a commit that referenced this pull request May 2, 2017
…rs,Items
Add Python API for `ALSModel` methods `recommendForAllUsers`, `recommendForAllItems`
## How was this patch tested?
New doc tests.
Author: Nick Pentreath <nickp@za.ibm.com>
Closes#17622 from MLnick/SPARK-20300-pyspark-recall.
(cherry picked from commit e300a5a)
Signed-off-by: Nick Pentreath <nickp@za.ibm.com>
@asfgitasfgit closed this in e300a5aMay 2, 2017
@MLnick
MLnick deleted the SPARK-20300-pyspark-recall branch May 2, 2017 09:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MLnick@SparkQA@viirya