Uh oh!
There was an error while loading. Please reload this page.
[SQL] [SPARK-2826] Reduce the memory copy while building the hashmap for HashOuterJoin - #1765
Closed
chenghao-intel wants to merge 1 commit into
Closed
[SQL] [SPARK-2826] Reduce the memory copy while building the hashmap for HashOuterJoin#1765chenghao-intel wants to merge 1 commit into
chenghao-intel wants to merge 1 commit into
Conversation
SparkQA
commented
Aug 4, 2014
QA tests have started for PR 1765. This patch merges cleanly. |
SparkQA
commented
Aug 4, 2014
QA results for PR 1765: |
Contributor
There was a problem hiding this comment.
This is a fairly minor nit but defining EMPTY_LIST instead of just using Seq.empty[Row]
- Takes up extra space in the class
- Requires double checked locking / lazy initialization logic for each access
- Requires the developer to find the variable and figure out what it means, instead of
Seq.empty[Row]which is standard scala.
All to save 4 characters?
ContributorAuthor
There was a problem hiding this comment.
Thank you @marmbrus , I will fix that as you suggested.
marmbrus
commented
Aug 12, 2014
Contributor
I went ahead and merged this since it improves perf and my only comments were cosmetic. Thanks! |
asfgit pushed a commit
that referenced
this pull request
Aug 12, 2014
…for HashOuterJoin This is a follow up for #1147 , this PR will improve the performance about 10% - 15% in my local tests. ``` Before: LeftOuterJoin: took 16750 ms ([3000000] records) LeftOuterJoin: took 15179 ms ([3000000] records) RightOuterJoin: took 15515 ms ([3000000] records) RightOuterJoin: took 15276 ms ([3000000] records) FullOuterJoin: took 19150 ms ([6000000] records) FullOuterJoin: took 18935 ms ([6000000] records) After: LeftOuterJoin: took 15218 ms ([3000000] records) LeftOuterJoin: took 13503 ms ([3000000] records) RightOuterJoin: took 13663 ms ([3000000] records) RightOuterJoin: took 14025 ms ([3000000] records) FullOuterJoin: took 16624 ms ([6000000] records) FullOuterJoin: took 16578 ms ([6000000] records) ``` Besides the performance improvement, I also do some clean up as suggested in #1147 Author: Cheng Hao <hao.cheng@intel.com> Closes#1765 from chenghao-intel/hash_outer_join_fixing and squashes the following commits: ab1f9e0 [Cheng Hao] Reduce the memory copy while building the hashmap (cherry picked from commit 5d54d71) Signed-off-by: Michael Armbrust <michael@databricks.com>
xiliu82 pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
…for HashOuterJoin This is a follow up for apache#1147 , this PR will improve the performance about 10% - 15% in my local tests. ``` Before: LeftOuterJoin: took 16750 ms ([3000000] records) LeftOuterJoin: took 15179 ms ([3000000] records) RightOuterJoin: took 15515 ms ([3000000] records) RightOuterJoin: took 15276 ms ([3000000] records) FullOuterJoin: took 19150 ms ([6000000] records) FullOuterJoin: took 18935 ms ([6000000] records) After: LeftOuterJoin: took 15218 ms ([3000000] records) LeftOuterJoin: took 13503 ms ([3000000] records) RightOuterJoin: took 13663 ms ([3000000] records) RightOuterJoin: took 14025 ms ([3000000] records) FullOuterJoin: took 16624 ms ([6000000] records) FullOuterJoin: took 16578 ms ([6000000] records) ``` Besides the performance improvement, I also do some clean up as suggested in apache#1147 Author: Cheng Hao <hao.cheng@intel.com> Closesapache#1765 from chenghao-intel/hash_outer_join_fixing and squashes the following commits: ab1f9e0 [Cheng Hao] Reduce the memory copy while building the hashmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up for #1147 , this PR will improve the performance about 10% - 15% in my local tests.
Besides the performance improvement, I also do some clean up as suggested in #1147