Skip to content

[SPARK-20358] [core] Executors failing stage on interrupted exception thrown by cancelled tasks - #17659

Closed
ericl wants to merge 1 commit into
apache:masterfrom
ericl:spark-20358
Closed

[SPARK-20358] [core] Executors failing stage on interrupted exception thrown by cancelled tasks#17659
ericl wants to merge 1 commit into
apache:masterfrom
ericl:spark-20358

Conversation

@ericl

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

This was a regression introduced by my earlier PR here: #17531

It turns out NonFatal() does not in fact catch InterruptedException.

How was this patch tested?

Extended cancellation unit test coverage. The first test fails before this patch.

cc @JoshRosen@mridulm

@SparkQA

Copy link
Copy Markdown

Test build #75861 has finished for PR 17659 at commit 607e11a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@ericl

Copy link
Copy Markdown
ContributorAuthor

Ping.

@yhuai

Copy link
Copy Markdown
Contributor

lgtm. Merging to master and branch-2.2.

asfgit pushed a commit that referenced this pull request Apr 20, 2017
…thrown by cancelled tasks
## What changes were proposed in this pull request?
This was a regression introduced by my earlier PR here: #17531
It turns out NonFatal() does not in fact catch InterruptedException.
## How was this patch tested?
Extended cancellation unit test coverage. The first test fails before this patch.
cc JoshRosen mridulm
Author: Eric Liang <ekl@databricks.com>
Closes#17659 from ericl/spark-20358.
(cherry picked from commit b2ebadf)
Signed-off-by: Yin Huai <yhuai@databricks.com>
jzhuge pushed a commit to jzhuge/spark that referenced this pull request Aug 20, 2018
…thrown by cancelled tasks
This was a regression introduced by my earlier PR here: apache#17531
It turns out NonFatal() does not in fact catch InterruptedException.
Extended cancellation unit test coverage. The first test fails before this patch.
cc JoshRosen mridulm
Author: Eric Liang <ekl@databricks.com>
Closesapache#17659 from ericl/spark-20358.
peter-toth pushed a commit to peter-toth/spark that referenced this pull request Oct 6, 2018
…thrown by cancelled tasks
## What changes were proposed in this pull request?
This was a regression introduced by my earlier PR here: apache#17531
It turns out NonFatal() does not in fact catch InterruptedException.
## How was this patch tested?
Extended cancellation unit test coverage. The first test fails before this patch.
cc JoshRosen mridulm
Author: Eric Liang <ekl@databricks.com>
Closesapache#17659 from ericl/spark-20358.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ericl@SparkQA@yhuai