Skip to content

[SPARK-20400][DOCS] Remove References to 3rd Party Vendor Tools - #17695

Closed
bllchmbrs wants to merge 2 commits into
apache:masterfrom
bllchmbrs:remove-vendor
Closed

[SPARK-20400][DOCS] Remove References to 3rd Party Vendor Tools#17695
bllchmbrs wants to merge 2 commits into
apache:masterfrom
bllchmbrs:remove-vendor

Conversation

@bllchmbrs

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Simple documentation change to remove explicit vendor references.

How was this patch tested?

NA

Please review http://spark.apache.org/contributing.html before opening a pull request.

@bllchmbrs

Copy link
Copy Markdown
ContributorAuthor

This should be on hold until a JIRA resolution, I'd like to hear what others say.

@gatorsmile

Copy link
Copy Markdown
Member

LGTM

@SparkQA

Copy link
Copy Markdown

Test build #75969 has finished for PR 17695 at commit 5692124.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowensrowen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per JIRA, this is

Comment threaddocs/configuration.md Outdated

The location of these configuration files varies across CDH and HDP versions, but
a common location is inside of `/etc/hadoop/conf`. Some tools, such as Cloudera Manager, create
The location of these configuration files varies across hadoop versions, but

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hadoop -> Hadoop

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment threaddocs/configuration.md
The location of these configuration files varies across CDH and HDP versions, but
a common location is inside of `/etc/hadoop/conf`. Some tools, such as Cloudera Manager, create
The location of these configuration files varies across hadoop versions, but
a common location is inside of `/etc/hadoop/conf`. Some tools create

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also won't matter either way, but is an example of an instance where naming a specific product is helpful information for users. There's no policy against this. But, it can be removed, sure, it's trivial either way.

@bllchmbrs

Copy link
Copy Markdown
ContributorAuthor

Thanks for the info @srowen - this should be better now.

@SparkQA

Copy link
Copy Markdown

Test build #76086 has finished for PR 17695 at commit e74c2d6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Comment threaddocs/configuration.md

The location of these configuration files varies across CDH and HDP versions, but
a common location is inside of `/etc/hadoop/conf`. Some tools, such as Cloudera Manager, create
The location of these configuration files varies across Hadoop versions, but

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I guess one issue I've realized now is that it doesn't really vary across versions of Hadoop but could vary according to packaging and distribution. If you change it again, also consider fixing the existing "mechanisms" typo in line 2253

@srowen

Copy link
Copy Markdown
Member

OK, merged it anyway to master/2.2

asfgit pushed a commit that referenced this pull request Apr 26, 2017
## What changes were proposed in this pull request?
Simple documentation change to remove explicit vendor references.
## How was this patch tested?
NA
Please review http://spark.apache.org/contributing.html before opening a pull request.
Author: anabranch <bill@databricks.com>
Closes#17695 from anabranch/remove-vendor.
(cherry picked from commit 7a36525)
Signed-off-by: Sean Owen <sowen@cloudera.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@bllchmbrs@gatorsmile@SparkQA@srowen