Skip to content

[SPARK-20367] Properly unescape column names of partitioning columns parsed from paths. - #17703

Closed
juliuszsompolski wants to merge 1 commit into
apache:masterfrom
juliuszsompolski:SPARK-20367
Closed

[SPARK-20367] Properly unescape column names of partitioning columns parsed from paths.#17703
juliuszsompolski wants to merge 1 commit into
apache:masterfrom
juliuszsompolski:SPARK-20367

Conversation

@juliuszsompolski

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

When infering partitioning schema from paths, the column in parsePartitionColumn should be unescaped with unescapePathName, just like it is being done in e.g. parsePathFragmentAsSeq.

How was this patch tested?

Added a test to FileIndexSuite.

@juliuszsompolski

Copy link
Copy Markdown
ContributorAuthor

cc @gatorsmile@cloud-fan

@hvanhovell

Copy link
Copy Markdown
Contributor

ok to test

@SparkQA

Copy link
Copy Markdown

Test build #75986 has finished for PR 17703 at commit c9a7ca1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmilegatorsmile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloud-fan

Copy link
Copy Markdown
Contributor

thanks, merging to master/2.2!

asfgit pushed a commit that referenced this pull request Apr 21, 2017
…parsed from paths.
## What changes were proposed in this pull request?
When infering partitioning schema from paths, the column in parsePartitionColumn should be unescaped with unescapePathName, just like it is being done in e.g. parsePathFragmentAsSeq.
## How was this patch tested?
Added a test to FileIndexSuite.
Author: Juliusz Sompolski <julek@databricks.com>
Closes#17703 from juliuszsompolski/SPARK-20367.
(cherry picked from commit 0368eb9)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
peter-toth pushed a commit to peter-toth/spark that referenced this pull request Oct 6, 2018
…parsed from paths.
## What changes were proposed in this pull request?
When infering partitioning schema from paths, the column in parsePartitionColumn should be unescaped with unescapePathName, just like it is being done in e.g. parsePathFragmentAsSeq.
## How was this patch tested?
Added a test to FileIndexSuite.
Author: Juliusz Sompolski <julek@databricks.com>
Closesapache#17703 from juliuszsompolski/SPARK-20367.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@juliuszsompolski@hvanhovell@SparkQA@cloud-fan@gatorsmile