Uh oh!
There was an error while loading. Please reload this page.
[SPARK-18127] Add hooks and extension points to Spark - #17724
Closed
sameeragarwal wants to merge 3 commits into
Closed
[SPARK-18127] Add hooks and extension points to Spark#17724sameeragarwal wants to merge 3 commits into
sameeragarwal wants to merge 3 commits into
Conversation
sameeragarwal
commented
Apr 21, 2017
MemberAuthor
cc @hvanhovell |
SparkQA
commented
Apr 21, 2017
Test build #76048 has finished for PR 17724 at commit
|
hvanhovell
commented
Apr 21, 2017
Contributor
LGTM |
SparkQA
commented
Apr 22, 2017
Test build #76049 has finished for PR 17724 at commit
|
| /** | ||
| * Inject extensions into the [[SparkSession]]. This allows a user to add Analyzer rules, | ||
| * Optimizer rules, Planning Strategies or a customized parser. | ||
| * |
Member
There was a problem hiding this comment.
In the JIRA, the target version is 2.2. Do we still plan to backport it to 2.2.0?
| * .master("...") | ||
| * .conf("...", true) | ||
| * .withExtensions { extensions => | ||
| * extensions.injectAnalyzerRule { session => |
Member
There was a problem hiding this comment.
injectAnalyzerRule -> buildResolutionRules?
gatorsmile
commented
Apr 22, 2017
Member
LGTM |
SparkQA
commented
Apr 25, 2017
Test build #76146 has finished for PR 17724 at commit
|
mridulm
commented
Apr 26, 2017
Contributor
Can we add SQL to pr title ? Extension to spark implies core, and means something different :-) |
asfgit pushed a commit
that referenced
this pull request
Apr 26, 2017
## What changes were proposed in this pull request? This patch adds support for customizing the spark session by injecting user-defined custom extensions. This allows a user to add custom analyzer rules/checks, optimizer rules, planning strategies or even a customized parser. ## How was this patch tested? Unit Tests in SparkSessionExtensionSuite Author: Sameer Agarwal <sameerag@cs.berkeley.edu> Closes#17724 from sameeragarwal/session-extensions. (cherry picked from commit caf3920) Signed-off-by: Xiao Li <gatorsmile@gmail.com>
gatorsmile
commented
Apr 26, 2017
Member
Thanks! Merging to master/2.2 |
sameeragarwal
commented
May 1, 2017
MemberAuthor
@mridulm my apologies -- I agree with your point but missed seeing this comment before the patch was merged. I hope the conf name ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch adds support for customizing the spark session by injecting user-defined custom extensions. This allows a user to add custom analyzer rules/checks, optimizer rules, planning strategies or even a customized parser.
How was this patch tested?
Unit Tests in SparkSessionExtensionSuite