[SPARK-20519][SQL][CORE]Modify to prevent some possible runtime exceptions by 10110346 · Pull Request #17796 · apache/spark

10110346 · 2017-04-28T03:14:55Z

Signed-off-by: liuxian liu.xian3@zte.com.cn

What changes were proposed in this pull request?

When the input parameter is null, may be a runtime exception occurs

How was this patch tested?

Existing unit tests

srowen

Don't make JIRAs for these; these are borderline not worth proposing, please.

srowen · 2017-04-28T07:39:46Z

This should be OK, but, it's already being checked for null in the line above.

10110346 · 2017-04-28T08:54:57Z

ok, thanks for review it@srowen

srowen · 2017-04-30T08:18:41Z

CC maybe @yhuai - OK to let tables(null) act like tables()? seems reasonable

srowen · 2017-05-04T10:06:57Z

@10110346 to be conservative, maybe remove the change to SQLContext. It's not clear to me that you are supposed to be able to call {{tables(null)}} because in this case you should call {{tables()}}. A NullPointerException seems like reasonable behavior.

However I think you could also expand the improvement for Utils.checkHost and checkHostPort. They all take this "message" argument which is pretty pointless. The message is a little different in many places and doesn't include the actual value most of the time. Just setting a complete valid message once in the method rather than taking it as an argument would further help.

10110346 · 2017-05-04T10:41:06Z

I quite agree with you.
I will do it,thanks @srowen

SparkQA · 2017-05-04T14:08:56Z

Test build #3689 has finished for PR 17796 at commit 88b9e8c.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

gatorsmile · 2017-05-05T06:31:38Z

ok to test

SparkQA · 2017-05-05T06:32:37Z

Test build #76482 has started for PR 17796 at commit 0b7aac2.

10110346 · 2017-05-05T07:39:11Z

Test FAILed. I don't know why.
Environment problem? Could you help me? thanks @gatorsmile

srowen

Other than the message change, yes, looks good

srowen · 2017-05-05T11:23:51Z

The message should be s"Expected hostname (not IP) but got $host"

srowen · 2017-05-05T11:23:56Z

Likewise here

SparkQA · 2017-05-06T04:24:14Z

Test build #76507 has finished for PR 17796 at commit 494928d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

10110346 · 2017-05-06T08:25:44Z

@srowen done, thank you very much.

srowen · 2017-05-06T09:37:01Z

Change "hostport" to "host and port"

Signed-off-by: liuxian <liu.xian3@zte.com.cn>

SparkQA · 2017-05-08T03:42:04Z

Test build #76557 has finished for PR 17796 at commit 0e879c8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

srowen · 2017-05-08T09:01:26Z

Merged to master

…ptions Signed-off-by: liuxian <liu.xian3zte.com.cn> ## What changes were proposed in this pull request? When the input parameter is null, may be a runtime exception occurs ## How was this patch tested? Existing unit tests Author: liuxian <liu.xian3@zte.com.cn> Closesapache#17796 from 10110346/wip_lx_0428.

srowen reviewed Apr 28, 2017
View reviewed changes

10110346 force-pushed the wip_lx_0428 branch 2 times, most recently from c5896c7 to e0eb912Compare April 28, 2017 08:51

srowen reviewed Apr 30, 2017
View reviewed changes

10110346 force-pushed the wip_lx_0428 branch from e0eb912 to 88b9e8cCompare May 4, 2017 12:08

10110346 force-pushed the wip_lx_0428 branch from 88b9e8c to 0b7aac2Compare May 5, 2017 01:52

srowen requested changes May 5, 2017
View reviewed changes

10110346 force-pushed the wip_lx_0428 branch from 0b7aac2 to 494928dCompare May 6, 2017 01:34

srowen reviewed May 6, 2017
View reviewed changes

Comment threadcore/src/main/scala/org/apache/spark/util/Utils.scala Outdated
srowenMay 6, 2017
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change "hostport" to "host and port"

Fix:Modify to prevent some possible runtime exception
0e879c8
Signed-off-by: liuxian <liu.xian3@zte.com.cn>

10110346 force-pushed the wip_lx_0428 branch from 494928d to 0e879c8Compare May 8, 2017 00:51

asfgit closed this in 0f820e2May 8, 2017

Uh oh!

Conversation

10110346 commented Apr 28, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

How was this patch tested?

Uh oh!

srowen left a comment

Choose a reason for hiding this comment

Uh oh!

srowenApr 28, 2017

Choose a reason for hiding this comment

Uh oh!

10110346 commented Apr 28, 2017

Uh oh!

srowenApr 30, 2017

Choose a reason for hiding this comment

Uh oh!

srowen commented May 4, 2017

Uh oh!

10110346 commented May 4, 2017

Uh oh!

SparkQA commented May 4, 2017

Uh oh!

gatorsmile commented May 5, 2017

Uh oh!

SparkQA commented May 5, 2017

Uh oh!

10110346 commented May 5, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

srowen left a comment

Choose a reason for hiding this comment

Uh oh!

srowenMay 5, 2017

Choose a reason for hiding this comment

Uh oh!

srowenMay 5, 2017

Choose a reason for hiding this comment

Uh oh!

SparkQA commented May 6, 2017

Uh oh!

10110346 commented May 6, 2017

Uh oh!

srowenMay 6, 2017

Choose a reason for hiding this comment

Uh oh!

SparkQA commented May 8, 2017

Uh oh!

srowen commented May 8, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

10110346 commented Apr 28, 2017•
edited
Loading

10110346 commented May 5, 2017•
edited
Loading