Skip to content

[SPARK-20620][TEST]Improve some unit tests for NullExpressionsSuite and TypeCoercionSuite - #17880

Closed
10110346 wants to merge 1 commit into
apache:masterfrom
10110346:wip_lx_0506
Closed

[SPARK-20620][TEST]Improve some unit tests for NullExpressionsSuite and TypeCoercionSuite#17880
10110346 wants to merge 1 commit into
apache:masterfrom
10110346:wip_lx_0506

Conversation

@10110346

@1011034610110346 commented May 6, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

add more datatype for some unit tests

How was this patch tested?

unit tests

gatorsmile
gatorsmile reviewed May 6, 2017
View reviewed changes
Comment thread...catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NullExpressionsSuite.scala Outdated

@gatorsmilegatorsmileMay 6, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is part of the test case test("coalesce casts") in TypeCoercionSuite. If you want, you can improve that test case.

gatorsmile
gatorsmile reviewed May 6, 2017
View reviewed changes
Comment thread...catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NullExpressionsSuite.scala Outdated

@gatorsmilegatorsmileMay 6, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same for this. It is being covered by the test case test("type coercion for If") in TypeCoercionSuite. If you want, you can improve that test case.

@10110346

10110346 commented May 7, 2017

Copy link
Copy Markdown
ContributorAuthor

@gatorsmile thanks,l will do it.

@10110346
10110346force-pushed the wip_lx_0506 branch 2 times, most recently from c75c36b to 3f99750CompareMay 8, 2017 03:42
@1011034610110346 changed the title [SPARK-20620][TEST]Add some unit tests into NullExpressionsSuite[SPARK-20620][TEST]Improve some unit tests for NullExpressionsSuite and TypeCoercionSuiteMay 8, 2017
HyukjinKwon
HyukjinKwon reviewed May 8, 2017
View reviewed changes
Comment threadsql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala Outdated

@HyukjinKwonHyukjinKwonMay 8, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I guess this should be longLit )

@SparkQA

SparkQA commented May 8, 2017

Copy link
Copy Markdown

Test build #3699 has finished for PR 17880 at commit 3f99750.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@10110346

10110346 commented May 19, 2017

Copy link
Copy Markdown
ContributorAuthor

I have modify Scala style.
Test is not started, could you help trigger it,thanks @HyukjinKwon@gatorsmile

@SparkQA

SparkQA commented May 19, 2017

Copy link
Copy Markdown

Test build #3731 has finished for PR 17880 at commit 3110f0f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile

gatorsmile commented May 29, 2017

Copy link
Copy Markdown
Member

retest this please

@gatorsmile

gatorsmile commented May 29, 2017

Copy link
Copy Markdown
Member

LGTM pending Jenkins.

@SparkQA

SparkQA commented May 29, 2017

Copy link
Copy Markdown

Test build #77507 has finished for PR 17880 at commit 3110f0f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@10110346

10110346 commented Jun 5, 2017

Copy link
Copy Markdown
ContributorAuthor

Test passed, thanks. @gatorsmile

@gatorsmile

gatorsmile commented Jun 10, 2017

Copy link
Copy Markdown
Member

retest this please

@SparkQA

SparkQA commented Jun 10, 2017

Copy link
Copy Markdown

Test build #77871 has finished for PR 17880 at commit 5b19b91.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

dataknocker pushed a commit to dataknocker/spark that referenced this pull request Jun 16, 2017
@10110346wangzejie
[SPARK-20620][TEST] Improve some unit tests for NullExpressionsSuite …
cdb26eb
…and TypeCoercionSuite
## What changes were proposed in this pull request?
add more datatype for some unit tests
## How was this patch tested?
unit tests
Author: liuxian <liu.xian3@zte.com.cn>
Closesapache#17880 from 10110346/wip_lx_0506.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HyukjinKwonHyukjinKwonHyukjinKwon left review comments
@gatorsmilegatorsmilegatorsmile left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@10110346@SparkQA@gatorsmile@HyukjinKwon