Uh oh!
There was an error while loading. Please reload this page.
[SPARK-20661][SPARKR][TEST][FOLLOWUP] SparkR tableNames() test fails - #17905
[SPARK-20661][SPARKR][TEST][FOLLOWUP] SparkR tableNames() test fails#17905felixcheung wants to merge 3 commits into
Conversation
falaki
commented
May 9, 2017
@felixcheung this approach is fine, but I think it is better if unit tests do not leave any side-effects to begin with. In this case every test should clean up state before and after (similar to |
that I agree completely, @falaki - looks like tests fail apparently when running Scala tests before running R tests |
I think this might be the reason? @yhuai@gatorsmile@ueshin |
yhuai
commented
May 9, 2017
@felixcheung you are right. That is the problem. |
yhuai
commented
May 9, 2017
@falaki's PR did not actually trigger that test. |
yhuai
commented
May 9, 2017
lgtm |
felixcheung
commented
May 9, 2017
hmm, spoke too soon I think - looks to me like all the |
yhuai
commented
May 9, 2017
i see. I think d4c1a9d is good. How about we get it checked in first (after jenkins passes)? |
felixcheung
commented
May 9, 2017
right. I think it's a good way to decouple R tests from any earlier states and also not to mask the error/leak. I'll get that in when Jenkins pass (and see if I could figure out what is leaked) |
gatorsmile
commented
May 9, 2017
How about #17908? It tries to reset the cataloged metadata objects and temporary objects. |
SparkQA
commented
May 9, 2017
Test build #76612 has finished for PR 17905 at commit
|
felixcheung
commented
May 9, 2017
ok Jenkins passes, I'm going to merge this in since there are a bunch of PR failing because of this, even when they say it's up-to-date with master. |
felixcheung
commented
May 9, 2017
merged to master/2.2 |
## What changes were proposed in this pull request? Change it to check for relative count like in this test https://github.com/apache/spark/blame/master/R/pkg/inst/tests/testthat/test_sparkSQL.R#L3355 for catalog APIs ## How was this patch tested? unit tests, this needs to combine with another commit with SQL change to check Author: Felix Cheung <felixcheung_m@hotmail.com> Closes#17905 from felixcheung/rtabletests. (cherry picked from commit b952b44) Signed-off-by: Felix Cheung <felixcheung@apache.org>
SparkQA
commented
May 9, 2017
Test build #76634 has started for PR 17905 at commit |
AmplabJenkins
commented
May 9, 2017
Test FAILed. |
## What changes were proposed in this pull request? Change it to check for relative count like in this test https://github.com/apache/spark/blame/master/R/pkg/inst/tests/testthat/test_sparkSQL.R#L3355 for catalog APIs ## How was this patch tested? unit tests, this needs to combine with another commit with SQL change to check Author: Felix Cheung <felixcheung_m@hotmail.com> Closesapache#17905 from felixcheung/rtabletests.
What changes were proposed in this pull request?
Change it to check for relative count like in this test https://github.com/apache/spark/blame/master/R/pkg/inst/tests/testthat/test_sparkSQL.R#L3355 for catalog APIs
How was this patch tested?
unit tests, this needs to combine with another commit with SQL change to check