Skip to content

[DOCS][SPARKR] Use verbose names for family annotations in functions.R - #17976

Closed
zero323 wants to merge 2 commits into
apache:masterfrom
zero323:SPARKR-FUNCTIONS-DOCSTRINGS
Closed

[DOCS][SPARKR] Use verbose names for family annotations in functions.R#17976
zero323 wants to merge 2 commits into
apache:masterfrom
zero323:SPARKR-FUNCTIONS-DOCSTRINGS

Conversation

@zero323

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

  • Change current short annotations (same as Scala @group) to verbose names (same as Scala @groupname).

    Before:

    image

    After:
    image

  • Add missing @family annotations.

How was this patch tested?

check-cran.R (skipping tests), manual inspection.

@zero323

Copy link
Copy Markdown
MemberAuthor

Note: if multiple functions use the same @rdname, there is only @family annotation to avoid duplicated See also section.

@SparkQA

Copy link
Copy Markdown

Test build #76906 has finished for PR 17976 at commit a006f32.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheungfelixcheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixcheung

Copy link
Copy Markdown
Member

merged to master. thanks!

@zero323

Copy link
Copy Markdown
MemberAuthor

Thanks Felix!

robert3005 pushed a commit to palantir/spark that referenced this pull request May 19, 2017
## What changes were proposed in this pull request?
- Change current short annotations (same as Scala `group`) to verbose names (same as Scala `groupname`).
Before:
![image](https://cloud.githubusercontent.com/assets/1554276/26033909/9a98b596-38b4-11e7-961e-15fd9ea7440d.png)
After:
![image](https://cloud.githubusercontent.com/assets/1554276/26033903/727a9944-38b4-11e7-8873-b09c553f4ec3.png)
- Add missing `family` annotations.
## How was this patch tested?
`check-cran.R` (skipping tests), manual inspection.
Author: zero323 <zero323@users.noreply.github.com>
Closesapache#17976 from zero323/SPARKR-FUNCTIONS-DOCSTRINGS.
lycplus pushed a commit to lycplus/spark that referenced this pull request May 24, 2017
## What changes were proposed in this pull request?
- Change current short annotations (same as Scala `group`) to verbose names (same as Scala `groupname`).
Before:
![image](https://cloud.githubusercontent.com/assets/1554276/26033909/9a98b596-38b4-11e7-961e-15fd9ea7440d.png)
After:
![image](https://cloud.githubusercontent.com/assets/1554276/26033903/727a9944-38b4-11e7-8873-b09c553f4ec3.png)
- Add missing `family` annotations.
## How was this patch tested?
`check-cran.R` (skipping tests), manual inspection.
Author: zero323 <zero323@users.noreply.github.com>
Closesapache#17976 from zero323/SPARKR-FUNCTIONS-DOCSTRINGS.
@zero323
zero323 deleted the SPARKR-FUNCTIONS-DOCSTRINGS branch February 2, 2020 17:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@zero323@SparkQA@felixcheung