Skip to content

[SPARK-20781] the location of Dockerfile in docker.properties.templat is wrong - #18013

Closed
liu-zhaokun wants to merge 1 commit into
apache:masterfrom
liu-zhaokun:dockerfile_location
Closed

[SPARK-20781] the location of Dockerfile in docker.properties.templat is wrong#18013
liu-zhaokun wants to merge 1 commit into
apache:masterfrom
liu-zhaokun:dockerfile_location

Conversation

@liu-zhaokun

Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/SPARK-20781
the location of Dockerfile in docker.properties.template should be "../external/docker/spark-mesos/Dockerfile"

@SparkQA

Copy link
Copy Markdown

Test build #3717 has started for PR 18013 at commit a0830c1.

@liu-zhaokun

Copy link
Copy Markdown
ContributorAuthor

@srowen
Hi,could you help me merge this PR?

@srowen

Copy link
Copy Markdown
Member

Same, tests haven't passed. You do not want to ping nearly this often

@SparkQA

Copy link
Copy Markdown

Test build #3724 has started for PR 18013 at commit a0830c1.

@SparkQA

Copy link
Copy Markdown

Test build #3735 has finished for PR 18013 at commit a0830c1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

Copy link
Copy Markdown

Test build #3738 has finished for PR 18013 at commit a0830c1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun

Copy link
Copy Markdown
Member

+1, LGTM, too.

asfgit pushed a commit that referenced this pull request May 19, 2017
… is wrong
[https://issues.apache.org/jira/browse/SPARK-20781](https://issues.apache.org/jira/browse/SPARK-20781)
the location of Dockerfile in docker.properties.template should be "../external/docker/spark-mesos/Dockerfile"
Author: liuzhaokun <liu.zhaokun@zte.com.cn>
Closes#18013 from liu-zhaokun/dockerfile_location.
(cherry picked from commit 749418d)
Signed-off-by: Sean Owen <sowen@cloudera.com>
asfgit pushed a commit that referenced this pull request May 19, 2017
… is wrong
[https://issues.apache.org/jira/browse/SPARK-20781](https://issues.apache.org/jira/browse/SPARK-20781)
the location of Dockerfile in docker.properties.template should be "../external/docker/spark-mesos/Dockerfile"
Author: liuzhaokun <liu.zhaokun@zte.com.cn>
Closes#18013 from liu-zhaokun/dockerfile_location.
(cherry picked from commit 749418d)
Signed-off-by: Sean Owen <sowen@cloudera.com>
lycplus pushed a commit to lycplus/spark that referenced this pull request May 24, 2017
… is wrong
[https://issues.apache.org/jira/browse/SPARK-20781](https://issues.apache.org/jira/browse/SPARK-20781)
the location of Dockerfile in docker.properties.template should be "../external/docker/spark-mesos/Dockerfile"
Author: liuzhaokun <liu.zhaokun@zte.com.cn>
Closesapache#18013 from liu-zhaokun/dockerfile_location.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@liu-zhaokun@SparkQA@srowen@dongjoon-hyun