Uh oh!
There was an error while loading. Please reload this page.
[SPARK-20815] [SPARKR] NullPointerException in RPackageUtils#checkManifestForR - #18040
Closed
jrshust wants to merge 3 commits into
Closed
[SPARK-20815] [SPARKR] NullPointerException in RPackageUtils#checkManifestForR#18040jrshust wants to merge 3 commits into
jrshust wants to merge 3 commits into
Conversation
felixcheung
commented
May 20, 2017
Member
Jenkins, ok to test |
SparkQA
commented
May 20, 2017
Test build #77128 has finished for PR 18040 at commit
|
| } | ||
| mani | ||
| mani | ||
| } else null |
Member
There was a problem hiding this comment.
I think typically Spark style is to have the else statement in separate line enclosed with {} like
} else {
null
}
| val jarStream = new JarOutputStream(jarFileStream, manifest) | ||
| val jarStream = if (manifest != null) { | ||
| new JarOutputStream(jarFileStream, manifest) | ||
| } else new JarOutputStream(jarFileStream) |
felixcheung
commented
May 22, 2017
Member
@jrshust would you have a chance to address a few minor comments? |
jrshust
commented
May 22, 2017
ContributorAuthor
@felixcheung yep sorry will address today! |
SparkQA
commented
May 22, 2017
Test build #77195 has started for PR 18040 at commit |
felixcheung
commented
May 22, 2017
Member
hmm that's odd |
jrshust
commented
May 22, 2017
ContributorAuthor
Yeah I'm a bit confused the last build was fine and this one just had style changes. What are the next steps here? Is that a red herring or was it actually aborted? |
felixcheung
commented
May 22, 2017
Member
Jenkins, retest this please |
felixcheung
commented
May 22, 2017
Member
it looks like build jobs are killed, let's try again |
SparkQA
commented
May 23, 2017
Test build #77205 has finished for PR 18040 at commit
|
asfgit pushed a commit
that referenced
this pull request
May 23, 2017
…festForR ## What changes were proposed in this pull request? - Add a null check to RPackageUtils#checkManifestForR so that jars w/o manifests don't NPE. ## How was this patch tested? - Unit tests and manual tests. Author: James Shuster <jshuster@palantir.com> Closes#18040 from jrshust/feature/r-package-utils. (cherry picked from commit 4dbb63f) Signed-off-by: Felix Cheung <felixcheung@apache.org>
felixcheung
commented
May 23, 2017
Member
merged to master/2.2, thanks! |
lycplus pushed a commit
to lycplus/spark
that referenced
this pull request
May 24, 2017
…festForR ## What changes were proposed in this pull request? - Add a null check to RPackageUtils#checkManifestForR so that jars w/o manifests don't NPE. ## How was this patch tested? - Unit tests and manual tests. Author: James Shuster <jshuster@palantir.com> Closesapache#18040 from jrshust/feature/r-package-utils.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?