Uh oh!
There was an error while loading. Please reload this page.
[Jenkins] Fix Jenkins not posting to Github sometimes - #1809
Closed
andrewor14 wants to merge 4 commits into
Closed
Conversation
andrewor14
commented
Aug 8, 2014
ContributorAuthor
test this please |
nchammas
commented
Aug 8, 2014
Contributor
Andrew, could you post an example of a class definition that causes this? I'm working on a related PR, so I'm curious. Also, have you looked into using |
andrewor14
commented
Aug 8, 2014
ContributorAuthor
Oh interesting, I didn't realize there was a related PR. Try adding a default parameter to your class: This is because the curl doesn't escape the double quotes properly. I'm having some difficulty trying to get Jenkins to test this PR, however, so maybe you can try to fix this in yours. |
nchammas
commented
Aug 8, 2014
Contributor
Yeah, Jenkins and I are good buddies now. Heh. I'll take a crack at fixing this in my PR in parallel. |
andrewor14
commented
Aug 8, 2014
ContributorAuthor
Let me know once you fix it so I can give up on grabbing Jenkin's attention and close this PR. |
nchammas
commented
Aug 8, 2014
Contributor
I think I've got it. Check it out. I also have the typo fixed in my PR, btw. (Fixed by removing the entire sentence, actually. 🤘) |
asfgit pushed a commit
that referenced
this pull request
Aug 15, 2014
You can find the [discussion that motivated this PR here](http://mail-archives.apache.org/mod_mbox/spark-dev/201408.mbox/%3CCABPQxssy0ri2QAz=cc9Tx+EXYWARm7pNcVm8apqCwc-esLbO4Qmail.gmail.com%3E). As described in [SPARK-2912](https://issues.apache.org/jira/browse/SPARK-2912), the goal of this PR (and related ones to come) is to include useful detail in Spark QA's messages that are intended to make a committer's job easier to do. Since this work depends on Jenkins, I cannot test this locally. Hence, I will be iterating via this PR. Notes: * This is a duplicate of a [previous PR](#1811), without the extraneous commits. * This PR also resolves an issue targeted by [another open PR](#1809). Closes#1809. Author: Nicholas Chammas <nicholas.chammas@gmail.com> Author: nchammas <nicholas.chammas@gmail.com> Closes#1816 from nchammas/master and squashes the following commits: c1be644 [Nicholas Chammas] [SPARK-2912] include commit hash in messages 8f641ac [nchammas] Merge pull request #7 from apache/master
xiliu82 pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
You can find the [discussion that motivated this PR here](http://mail-archives.apache.org/mod_mbox/spark-dev/201408.mbox/%3CCABPQxssy0ri2QAz=cc9Tx+EXYWARm7pNcVm8apqCwc-esLbO4Qmail.gmail.com%3E). As described in [SPARK-2912](https://issues.apache.org/jira/browse/SPARK-2912), the goal of this PR (and related ones to come) is to include useful detail in Spark QA's messages that are intended to make a committer's job easier to do. Since this work depends on Jenkins, I cannot test this locally. Hence, I will be iterating via this PR. Notes: * This is a duplicate of a [previous PR](apache#1811), without the extraneous commits. * This PR also resolves an issue targeted by [another open PR](apache#1809). Closesapache#1809. Author: Nicholas Chammas <nicholas.chammas@gmail.com> Author: nchammas <nicholas.chammas@gmail.com> Closesapache#1816 from nchammas/master and squashes the following commits: c1be644 [Nicholas Chammas] [SPARK-2912] include commit hash in messages 8f641ac [nchammas] Merge pull request apache#7 from apache/master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If your diff has "class" and double quotes on the same line, Jenkins does not post back to github because the diff is not properly escaped.