Skip to content

[BACKPORT-2.2][SPARK-19372][SQL] Fix throwing a Java exception at df.fliter() due to 64KB bytecode size limit - #18119

Closed
kiszk wants to merge 1 commit into
apache:branch-2.2from
kiszk:SPARK-19372-branch22
Closed

[BACKPORT-2.2][SPARK-19372][SQL] Fix throwing a Java exception at df.fliter() due to 64KB bytecode size limit#18119
kiszk wants to merge 1 commit into
apache:branch-2.2from
kiszk:SPARK-19372-branch22

Conversation

@kiszk

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This PR is backport of #17087 to Spark 2.2

How was this patch tested?

Add a test suite into DataFrameSuite

@SparkQA

Copy link
Copy Markdown

Test build #77419 has finished for PR 18119 at commit e39bda0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class InterpretedPredicate(expression: Expression) extends BasePredicate

@kiszk

Copy link
Copy Markdown
MemberAuthor

ping @zsxwing

@marmbrus

Copy link
Copy Markdown
Contributor

Since this is purely a fallback for a case that would error, it seems possibly okay to include in 2.2. @zsxwing could you take a look and make sure I'm right?

@zsxwing

Copy link
Copy Markdown
Member

@kiszk I just pushed #17087 directly to branch-2.2 since there is no conflict. Could you close this one?

In addition, I noticed that the test outputs too many logs, could you submit a PR to use testQuietly instead?

@kiszk

Copy link
Copy Markdown
MemberAuthor

@zsxwing , sure, I submit another PR.

@kiszkkiszk closed this May 27, 2017
@dongjoon-hyun

Copy link
Copy Markdown
Member

Thank you so much!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@kiszk@SparkQA@marmbrus@zsxwing@dongjoon-hyun